fix(upgrade): upgrade Directive facade should not return different instance from constructor #27660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
type: bug/fix
comp: upgrade/dynamic
freq1: low
target: major
petebacondarwin
commented
Dec 13, 2018
petebacondarwin
commented
Dec 13, 2018
|
You can preview 1ef6aa4 at https://pr27660-1ef6aa4.ngbuilds.io/. |
petebacondarwin
force-pushed
the
fw-812
branch
from
1ef6aa4
to
c096bf7
Compare
|
You can preview c096bf7 at https://pr27660-c096bf7.ngbuilds.io/. |
petebacondarwin
force-pushed
the
fw-812
branch
from
c096bf7
to
b809816
Compare
|
You can preview b809816 at https://pr27660-b809816.ngbuilds.io/. |
petebacondarwin
force-pushed
the
fw-812
branch
from
b809816
to
4a1e843
Compare
|
You can preview 4a1e843 at https://pr27660-4a1e843.ngbuilds.io/. |
petebacondarwin
changed the title
The changes here clarify that we now have a better description of the root cause of the failure.
…stance from constructor In ngUpgrade (dynamic) we create a dynamic Angular `Directive` that wraps AngularJS components that are being upgraded. The constructor of this `Directive` class returns a different instance than `this`. It is this instance that actually contains the life-cycle hook handlers. This would break in ivy, since the methods on the prototype of the original class are wired up, rather than the instance methods. This results in hooks like `ngOnInit` not being called. This commit refactors the code to extend the inner class that was being returned so that the prototype chain is correct for both ViewEngine and ivy. This change resolves a number of failing ivy tests, but also exposes other failures that were masked by this issue. The tests have been updated accordingly. (FW-812)
petebacondarwin
force-pushed
the
fw-812
branch
from
4a1e843
to
9cb16e0
Compare
|
You can preview 9cb16e0 at https://pr27660-9cb16e0.ngbuilds.io/. |
|
You can preview 0ba061f at https://pr27660-0ba061f.ngbuilds.io/. |
…rent instance from constructor
petebacondarwin
force-pushed
the
fw-812
branch
from
0ba061f
to
1f7c9bf
Compare
|
You can preview 1f7c9bf at https://pr27660-1f7c9bf.ngbuilds.io/. |
mhevery
approved these changes
Dec 17, 2018
mhevery
pushed a commit
that referenced
this pull request
Dec 17, 2018
…stance from constructor (#27660) In ngUpgrade (dynamic) we create a dynamic Angular `Directive` that wraps AngularJS components that are being upgraded. The constructor of this `Directive` class returns a different instance than `this`. It is this instance that actually contains the life-cycle hook handlers. This would break in ivy, since the methods on the prototype of the original class are wired up, rather than the instance methods. This results in hooks like `ngOnInit` not being called. This commit refactors the code to extend the inner class that was being returned so that the prototype chain is correct for both ViewEngine and ivy. This change resolves a number of failing ivy tests, but also exposes other failures that were masked by this issue. The tests have been updated accordingly. (FW-812) PR Close #27660
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
The changes here clarify that we now have a better description of the root cause of the failure. PR Close angular#27660
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…stance from constructor (angular#27660) In ngUpgrade (dynamic) we create a dynamic Angular `Directive` that wraps AngularJS components that are being upgraded. The constructor of this `Directive` class returns a different instance than `this`. It is this instance that actually contains the life-cycle hook handlers. This would break in ivy, since the methods on the prototype of the original class are wired up, rather than the instance methods. This results in hooks like `ngOnInit` not being called. This commit refactors the code to extend the inner class that was being returned so that the prototype chain is correct for both ViewEngine and ivy. This change resolves a number of failing ivy tests, but also exposes other failures that were masked by this issue. The tests have been updated accordingly. (FW-812) PR Close angular#27660
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ngUpgrade (dynamic) we create a dynamic Angular
Directivethat wraps AngularJS componentsthat are being upgraded. The constructor of this
Directiveclass returns a different instancethan
this. It is this instance that actually contains the life-cycle hook handlers.This would break in ivy, since the methods on the prototype of the original class are wired up,
rather than the instance methods. This results in hooks like
ngOnInitnot being called.This PR refactors the code to extend the inner class that was being returned so that the
prototype chain is correct for both ViewEngine and ivy.
This change resolves a number of failing ivy tests, but also exposes other failures that were
masked by this issue. The tests have been updated accordingly.