Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update gulp-clang-format dependency #27712

Closed
wants to merge 1 commit into from
Closed

build: update gulp-clang-format dependency #27712

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

Currently running the gulp tasks to format code does not work because the through2 version (which depends on readable-stream) and is used by gulp-clang-format is very outdated and seems to cause exceptions like:

Error: no writecb in Transform class
    at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33)
    at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12)

Updating to the latest version of gulp-clang-format that comes with angular/gulp-clang-format@10cbb7f, seems to fix this.

Note: This issue seems to depend on the platform because I didn't run into it on MacOS nor Linux. I got the failure on Windows. Other's don't run into in on Windows, but updating shouldn't hurt anyway.

@devversion
build: update gulp-clang-format dependency
ee9f7de 
Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like:

```
Error: no writecb in Transform class
    at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33)
    at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12)
```

Updating to the latest version of `gulp-clang-format` that comes with angular/gulp-clang-format@10cbb7f, seems to fix this.

**Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest
version should just improve things.
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: build & ci Related the build and CI infrastructure of the project labels Dec 17, 2018
IgorMinar
IgorMinar approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 18, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 18, 2018
@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Dec 18, 2018
@IgorMinar
Copy link
Contributor

@devversion I changed this PR to target both master and patch - in general we are trying hard to keep the infrastructure up to date on the most recent patch branch to minimize disruption when cherry-picking changes. thanks for the update.

@mhevery mhevery closed this in d766ad0 Dec 18, 2018
mhevery pushed a commit that referenced this pull request Dec 18, 2018
@devversion @mhevery
build: update gulp-clang-format dependency (#27712)
ad16025 
Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like:

```
Error: no writecb in Transform class
    at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33)
    at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12)
```

Updating to the latest version of `gulp-clang-format` that comes with angular/gulp-clang-format@10cbb7f, seems to fix this.

**Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest
version should just improve things.

PR Close #27712
devversion added a commit to devversion/angular that referenced this pull request Dec 19, 2018
@devversion
Revert "build: update gulp-clang-format dependency (angular#27712)"
ab20ee7 
This reverts commit d766ad0.

As discussed per chat, we want to temporarily revert that change because `gulp-clang-format` expects a more recent version of `clang-format` which comes with new style updates. In order to make sure that the formatting will be enforced in the meanwhile, we need to revert the update.
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
@devversion @IgorMinar
build: update gulp-clang-format dependency (angular#27712)
6bec4d0 
Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like:

```
Error: no writecb in Transform class
    at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33)
    at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12)
```

Updating to the latest version of `gulp-clang-format` that comes with angular/gulp-clang-format@10cbb7f, seems to fix this.

**Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest
version should just improve things.

PR Close angular#27712
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
@devversion @IgorMinar
build: update gulp-clang-format dependency (angular#27712)
0e516b1 
Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like:

```
Error: no writecb in Transform class
    at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33)
    at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12)
```

Updating to the latest version of `gulp-clang-format` that comes with angular/gulp-clang-format@10cbb7f, seems to fix this.

**Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest
version should just improve things.

PR Close angular#27712
matsko pushed a commit that referenced this pull request Dec 19, 2018
@devversion @matsko
Revert "build: update gulp-clang-format dependency (#27712)" (#27759)
a3debf6 
This reverts commit d766ad0.

As discussed per chat, we want to temporarily revert that change because `gulp-clang-format` expects a more recent version of `clang-format` which comes with new style updates. In order to make sure that the formatting will be enforced in the meanwhile, we need to revert the update.

PR Close #27759
matsko pushed a commit that referenced this pull request Dec 19, 2018
@devversion @matsko
Revert "build: update gulp-clang-format dependency (#27712)" (#27759)
0604527 
This reverts commit d766ad0.

As discussed per chat, we want to temporarily revert that change because `gulp-clang-format` expects a more recent version of `clang-format` which comes with new style updates. In order to make sure that the formatting will be enforced in the meanwhile, we need to revert the update.

PR Close #27759
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@devversion @ngfelixl
build: update gulp-clang-format dependency (angular#27712)
916b462 
Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like:

```
Error: no writecb in Transform class
    at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33)
    at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12)
```

Updating to the latest version of `gulp-clang-format` that comes with angular/gulp-clang-format@10cbb7f, seems to fix this.

**Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest
version should just improve things.

PR Close angular#27712
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@devversion @ngfelixl
Revert "build: update gulp-clang-format dependency (angular#27712)" (a…
6189147 
…ngular#27759)

This reverts commit d766ad0.

As discussed per chat, we want to temporarily revert that change because `gulp-clang-format` expects a more recent version of `clang-format` which comes with new style updates. In order to make sure that the formatting will be enforced in the meanwhile, we need to revert the update.

PR Close angular#27759
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devversion @IgorMinar @googlebot