Skip to content

Commit

Permalink
build: update gulp-clang-format dependency (angular#27712)
Browse files Browse the repository at this point in the history
Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like:

```
Error: no writecb in Transform class
    at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33)
    at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12)
```

Updating to the latest version of `gulp-clang-format` that comes with angular/gulp-clang-format@10cbb7f, seems to fix this.

**Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest
version should just improve things.

PR Close angular#27712
  • Loading branch information
devversion authored and mhevery committed Dec 18, 2018
1 parent f57916c commit d766ad0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 21 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"firefox-profile": "1.0.3",
"glob": "7.1.2",
"gulp": "3.9.1",
"gulp-clang-format": "1.0.23",
"gulp-clang-format": "1.0.27",
"gulp-connect": "5.0.0",
"gulp-conventional-changelog": "^2.0.3",
"gulp-filter": "^5.1.0",
Expand Down
29 changes: 9 additions & 20 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3482,18 +3482,17 @@ graphviz@0.0.7:
dependencies:
temp "~0.4.0"

gulp-clang-format@1.0.23:
version "1.0.23"
resolved "https://registry.yarnpkg.com/gulp-clang-format/-/gulp-clang-format-1.0.23.tgz#fe258586b83998491e632fc0c4fc0ecdfa10c89f"
integrity sha1-/iWFhrg5mEkeYy/AxPwOzfoQyJ8=
gulp-clang-format@1.0.27:
version "1.0.27"
resolved "https://registry.yarnpkg.com/gulp-clang-format/-/gulp-clang-format-1.0.27.tgz#c89716c26745703356c4ff3f2b0964393c73969e"
integrity sha512-Jj4PGuNXKdqVCh9fijvL7wdzma5TQRJz1vv8FjOjnSkfq3s/mvbdE/jq+5HG1c/q+jcYkXTEGkYT3CrdnJOLaQ==
dependencies:
clang-format "^1.0.32"
fancy-log "^1.3.2"
gulp-diff "^1.0.0"
gulp-util "^3.0.4"
pkginfo "^0.3.0"
plugin-error "^1.0.1"
stream-combiner2 "^1.1.1"
stream-equal "0.1.6"
through2 "^0.6.3"
through2 "^2.0.3"

gulp-connect@5.0.0:
version "5.0.0"
Expand Down Expand Up @@ -3562,7 +3561,7 @@ gulp-tslint@8.1.2:
map-stream "~0.0.7"
through "~2.3.8"

gulp-util@^3.0.0, gulp-util@^3.0.4, gulp-util@^3.0.6, gulp-util@~3.0.8:
gulp-util@^3.0.0, gulp-util@^3.0.6, gulp-util@~3.0.8:
version "3.0.8"
resolved "https://registry.yarnpkg.com/gulp-util/-/gulp-util-3.0.8.tgz#0054e1e744502e27c04c187c3ecc505dd54bbb4f"
integrity sha1-AFTh50RQLifATBh8PsxQXdVLu08=
Expand Down Expand Up @@ -6354,11 +6353,6 @@ pinkie@^2.0.0:
resolved "https://registry.yarnpkg.com/pinkie/-/pinkie-2.0.4.tgz#72556b80cfa0d48a974e80e77248e80ed4f7f870"
integrity sha1-clVrgM+g1IqXToDnckjoDtT3+HA=

pkginfo@^0.3.0:
version "0.3.1"
resolved "https://registry.yarnpkg.com/pkginfo/-/pkginfo-0.3.1.tgz#5b29f6a81f70717142e09e765bbeab97b4f81e21"
integrity sha1-Wyn2qB9wcXFC4J52W76rl7T4HiE=

plugin-error@^0.1.2:
version "0.1.2"
resolved "https://registry.yarnpkg.com/plugin-error/-/plugin-error-0.1.2.tgz#3b9bb3335ccf00f425e07437e19276967da47ace"
Expand Down Expand Up @@ -7804,11 +7798,6 @@ stream-counter@~0.2.0:
dependencies:
readable-stream "~1.1.8"

stream-equal@0.1.6:
version "0.1.6"
resolved "https://registry.yarnpkg.com/stream-equal/-/stream-equal-0.1.6.tgz#cc522fab38516012e4d4ee47513b147b72359019"
integrity sha1-zFIvqzhRYBLk1O5HUTsUe3I1kBk=

stream-to-array@~2.3.0:
version "2.3.0"
resolved "https://registry.yarnpkg.com/stream-to-array/-/stream-to-array-2.3.0.tgz#bbf6b39f5f43ec30bc71babcb37557acecf34353"
Expand Down Expand Up @@ -8027,7 +8016,7 @@ throttleit@~0.0.2:
resolved "https://registry.yarnpkg.com/throttleit/-/throttleit-0.0.2.tgz#cfedf88e60c00dd9697b61fdd2a8343a9b680eaf"
integrity sha1-z+34jmDADdlpe2H90qg0OptoDq8=

through2@^0.6.1, through2@^0.6.3:
through2@^0.6.1:
version "0.6.5"
resolved "https://registry.yarnpkg.com/through2/-/through2-0.6.5.tgz#41ab9c67b29d57209071410e1d7a7a968cd3ad48"
integrity sha1-QaucZ7KdVyCQcUEOHXp6lozTrUg=
Expand Down

0 comments on commit d766ad0

Please sign in to comment.