Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core): fix typo #28042

Closed
wants to merge 1 commit into from
Closed

docs(core): fix typo #28042

wants to merge 1 commit into from

Conversation

ernest-galbrun
Copy link
Contributor

@ernest-galbrun ernest-galbrun commented Jan 10, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ernest-galbrun ernest-galbrun requested a review from a team as a code owner January 10, 2019 13:15
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR type: bug/fix labels Jan 14, 2019
@ngbot ngbot bot added this to the Backlog milestone Jan 14, 2019
@brandonroberts brandonroberts added area: core Issues related to the framework runtime action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 14, 2019
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 14, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: This is a docs only change and should not impact g3. Please run presubmit

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 15, 2019
@AndrewKushnir
Copy link
Contributor

Presubmit

@AndrewKushnir
Copy link
Contributor

@brandonroberts I've rebased this PR on top of the latest master and run g3 presubmit to verify everything looks good. Could you please have a quick look at the changes to make sure there are no unexpected changes after rebase and return "merge" label back if everything is ok? Thank you.

@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 15, 2019
@brandonroberts
Copy link
Contributor

LGTM

AndrewKushnir pushed a commit that referenced this pull request Jan 15, 2019
@ernest-galbrun @AndrewKushnir
docs(core): fix typo (#28042)
9faad4b 
PR Close #28042
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@ernest-galbrun @AndrewKushnir
docs(core): fix typo (#28042)
5c56b77 
PR Close #28042
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
@ernest-galbrun @wKoza
docs(core): fix typo (angular#28042)
5fe6c0f 
PR Close angular#28042
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
@ernest-galbrun @wKoza
docs(core): fix typo (angular#28042)
02f88bc 
PR Close angular#28042
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@ernest-galbrun @ngfelixl
docs(core): fix typo (angular#28042)
df27059 
PR Close angular#28042
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ernest-galbrun @brandonroberts @AndrewKushnir @googlebot