test(ivy): move error-handling test to be handled at a later stage #28212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 4536530 at https://pr28212-4536530.ngbuilds.io/. |
|
So you are saying it's not really obsolete and still needs to be tackled at some point, right? |
kara
reviewed
Jan 18, 2019
kara
added
action: cleanup
Due to the fast moving nature of the Ivy codebase, the timing isn't right to make changes to how errors and reported and handled during the runtime. Once ivy is stable this test should be revisted because that stage there will be a better and more robust understanding of how ivy should recover from runtime errors. Jira Issue: FW-952
kara
added
action: merge
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 26, 2019
…ngular#28212) Due to the fast moving nature of the Ivy codebase, the timing isn't right to make changes to how errors and reported and handled during the runtime. Once ivy is stable this test should be revisted because that stage there will be a better and more robust understanding of how ivy should recover from runtime errors. Jira Issue: FW-952 PR Close angular#28212
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 26, 2019
…ngular#28212) Due to the fast moving nature of the Ivy codebase, the timing isn't right to make changes to how errors and reported and handled during the runtime. Once ivy is stable this test should be revisted because that stage there will be a better and more robust understanding of how ivy should recover from runtime errors. Jira Issue: FW-952 PR Close angular#28212
vetom
pushed a commit
to vetom/angular
that referenced
this pull request
Jan 31, 2019
…ngular#28212) Due to the fast moving nature of the Ivy codebase, the timing isn't right to make changes to how errors and reported and handled during the runtime. Once ivy is stable this test should be revisted because that stage there will be a better and more robust understanding of how ivy should recover from runtime errors. Jira Issue: FW-952 PR Close angular#28212
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fast moving nature of the Ivy codebase, the timing isn't right to make changes to how errors and reported and handled during the runtime.
Once ivy is stable this test should be revisted because that stage there will be a better and more robust understanding of how ivy should recover from runtime errors.
Jira Issue: FW-952