Skip to content

Commit

Permalink
test(ivy): move error-handling test to be handled at a later stage (a…
Browse files Browse the repository at this point in the history
…ngular#28212)

Due to the fast moving nature of the Ivy codebase, the timing isn't
right to make changes to how errors and reported and handled during the
runtime.

Once ivy is stable this test should be revisted because that stage there
will be a better and more robust understanding of how ivy should recover
from runtime errors.

Jira Issue: FW-952

PR Close angular#28212
  • Loading branch information
matsko authored and wKoza committed Jan 26, 2019
1 parent 32b88ec commit 0032c4c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/core/test/animation/animation_integration_spec.ts
Expand Up @@ -13,7 +13,7 @@ import {TestBed, fakeAsync, flushMicrotasks} from '@angular/core/testing';
import {ɵDomRendererFactory2} from '@angular/platform-browser';
import {ANIMATION_MODULE_TYPE, BrowserAnimationsModule, NoopAnimationsModule} from '@angular/platform-browser/animations';
import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter';
import {fixmeIvy, ivyEnabled} from '@angular/private/testing';
import {ivyEnabled, modifiedInIvy} from '@angular/private/testing';

const DEFAULT_NAMESPACE_ID = 'id';
const DEFAULT_COMPONENT_ID = '1';
Expand Down Expand Up @@ -3660,7 +3660,7 @@ const DEFAULT_COMPONENT_ID = '1';
expect(() => { TestBed.createComponent(Cmp); }).not.toThrowError();
});

fixmeIvy('FW-952 - Error recovery is handled differently in Ivy than VE')
modifiedInIvy('FW-952 - Error recovery is handled differently in Ivy than VE')
.it('should continue to clean up DOM-related animation artificats even if a compiler-level error is thrown midway',
() => {
@Component({
Expand Down

0 comments on commit 0032c4c

Please sign in to comment.