Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: yarn support version incremented up to 1.13.x (the latest version) #28360

Closed
wants to merge 1 commit into from

Conversation

jithil-kore
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
yarn support version incremented up to 1.13.x (the latest version). It's package config update which was blocking the development because unavailability of yarn old versions. Also, old version of yarn are not available, and it is stopping local setups. By this PR, the yarn package version will be support the latest yarn, and it will not block the dev to setup angular repo in local machines.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently if someone tries to setup the angular repo in local machines with latest version of yarn, the yarn command will failed because we are not supporting the yarn recent version. It is difficult to install the old versions of yarn which is not officially supported. So, the development will be getting blocked.

Issue Number: N/A

What is the new behavior?

The yarn support version has been upgraded. And so, yarn and related setups will not block a dev to build and run the local repo in their machine.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jithil-kore
Copy link
Contributor Author

@jenniferfell as we discussed on #28334, I'm creating a separate PR for yarn package upgrade. Please check.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs-infra changes

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

once #28393 lands we should increase the lower bound so that we don't have too many yarn versions floating around.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Jan 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 27, 2019
@jasonaden jasonaden closed this in ec414b4 Jan 29, 2019
jasonaden pushed a commit that referenced this pull request Jan 29, 2019
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants