fix(bazel): Bazel builder should resolve with require.resolve() #28478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in the Bazel builder in which the path to Bazel executable is constructed using the project path. For non-default project, the node_modules directory is actually one level above the project path. This PR fixes the bug by resolving node_modules with require.resolve(). It requires @bazel/bazel v0.22.1 because previous versions do not have index.js or main field in package.json and would cause node module resolution to fail. This has been tested with both bazel and ibazel.
kyliau
added
state: WIP
target: patch
matsko
pushed a commit
that referenced
this pull request
Feb 1, 2019
This commit fixes a bug in the Bazel builder in which the path to Bazel executable is constructed using the project path. For non-default project, the node_modules directory is actually one level above the project path. This PR fixes the bug by resolving node_modules with require.resolve(). It requires @bazel/bazel v0.22.1 because previous versions do not have index.js or main field in package.json and would cause node module resolution to fail. This has been tested with both bazel and ibazel. PR Close #28478
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the Bazel builder in which the path to Bazel
executable is constructed using the project path. For non-default
project, the node_modules directory is actually one level above the
project path.
This PR fixes the bug by resolving node_modules with require.resolve().
It requires @bazel/bazel v0.22.1 because previous versions do not have
index.js or main field in package.json and would cause node module
resolution to fail.
This has been tested with both bazel and ibazel.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information