New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable github bot CI rerun feature #29098
Conversation
Will there be a trigger to only re-run failed jobs? |
.github/angular-robot.yml
Outdated
# set to true to disable | ||
disabled: false | ||
# the label which when added triggers a rerun of the default CircleCI workflow | ||
triggerRerunLabel: 'Rerun CI at HEAD' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the at HEAD
mean? How is it different than Rerun CI
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IgorMinar wanted the label to reflect that the CI will run at the current HEAD of the targeted branch being merged into, usually master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All our CI runs at the HEAD of its target branch though:
Lines 66 to 79 in 5b134ca
# After checkout, rebase on top of target branch. | |
var_7: &post_checkout | |
run: | |
name: Rebase PR on target branch | |
command: > | |
if [[ -n "${CIRCLE_PR_NUMBER}" ]]; then | |
# User is required for rebase. | |
git config user.name "angular-ci" | |
git config user.email "angular-ci" | |
# Rebase PR on top of target branch. | |
node tools/rebase-pr.js angular/angular ${CIRCLE_PR_NUMBER} | |
else | |
echo "This build is not over a PR, nothing to do." | |
fi |
@brandonroberts the plan is to add this in the future, but the functionality for it will need to be added to the github robot first. |
16b93b2
to
eb90113
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
# set to true to disable | ||
disabled: false | ||
# the label which when added triggers a rerun of the default CircleCI workflow | ||
triggerRerunLabel: "PR action: rerun CI at HEAD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 PR action:
labels usually indicate that someone needs to do something. PR action: rerun CI at HEAD
sounds like someone needs to do it (vs it is done automatically for us).
Also, this label is not documented in docs/TRIAGE_AND_LABELS.md 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference: Documented it in #30171.
…_LABELS.md` Related to angular#29098.
…_LABELS.md` Related to angular#29098.
…_LABELS.md` Related to angular#29098.
…_LABELS.md` Related to angular#29098.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?