-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update TRIAGE_AND_LABELS.md
#30171
Conversation
1694f02
to
6d49d4d
Compare
docs/TRIAGE_AND_LABELS.md
Outdated
|
||
### `PR action: rerun CI at HEAD` | ||
* _**Who adds it:** Anybody._ | ||
* _**Who removes it:** ???_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the bot should remove it automatically - @ocombe I don't think that this is the case right now. Could we change the bot to remove the label after the CI is kicked off? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. actually adding the label doesn't seem to trigger the CI restart right now. is there a bug somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The firebase config wasn't updated when the PR was merged. I cleaned it, it removes it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rest looks reasonable to me, but I'll wait for others to chime in as well.
docs/TRIAGE_AND_LABELS.md
Outdated
@@ -167,16 +180,32 @@ Only the `PR action: merge` label means that the PR is ready for merging. | |||
## Special Labels | |||
|
|||
### `cla: yes`, `cla: no` | |||
* _**Who adds it:** @googlebot._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* _**Who adds it:** @googlebot._ | |
* _**Who adds it:** @googlebot, or a Googler manually overriding the status in case the bot got it wrong._ |
docs/TRIAGE_AND_LABELS.md
Outdated
Managed by googlebot. | ||
Indicates whether a PR has a CLA on file for its author(s). | ||
Only issues with `cla:yes` should be merged into master. | ||
|
||
### `aio: preview` | ||
* _**Who adds it:** Anybody. (Typically the author or a reviewer.)_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep in mind that only org members can add labels to PRs, so "Anybody" is misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use a "team member"
6d49d4d
to
e651869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rest looks good to me.
docs/TRIAGE_AND_LABELS.md
Outdated
* _**Who adds it:** Any team member._ | ||
* _**Who removes it:** The Angular Bot, once it triggers the CI rerun._ | ||
|
||
This label can be added to instruct the Angular Bot to rerun the CI jobs for the PR at latest HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary line break
e651869
to
3c6fdbf
Compare
* _**Who adds it:** Typically the PR author._ | ||
* _**Who removes it:** Whoever added it._ | ||
* `PR action: review` (optional): One or more reviews are pending. The label is optional, since the review status can be derived from GitHub's Reviewers interface. | ||
* _**Who adds it:** Any team member. The caretaker can use it to differentiate PRs pending review from merge-ready PRs._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this label is in a bad place. It's optional, somewhat redundant, anyone can add it, and at least 2 people are responsible for removing it. And yet it signals that there's still work (reviews) to be done, and shouldn't be merged.
I think the end result is that the label is ignored. The PR author might not know that someone added it. The reviewers might not bother to see if they are the last one and remove it. It can just stay there without anyone removing it indefinitely.
So what should the caretaker do? If they are to use their best judgement and validate it against the GH reviewers interface, what's the point of it to begin with? Might as well do without that redundant chore. If they are to respect it, then the PR author can find their PR sitting there with all reviews just because someone else decided to add the label at some point.
IMHO this label needs to be stricter or be done away with. I tend towards removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One benefit of this label is that it is not possible to filter the PR list view based on whether all the reviews have been approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I agree with @filipesilva. If there is no way for the caretaker to filter based on PRs pending reviews, we should come up with another way that can be better automated.
In any case, this PR was specifically about documenting what the label is currently used for, so 🤷♂
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR action: review
,PR action: rerun CI at HEAD