Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): update bazel managed yarn to 1.13.0 (same as CI version) #29311

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Mar 14, 2019

This PR updates bazel managed yarn.

Note: we tried using vendored_yarn previously but this caused major issues on Windows: bazelbuild/rules_nodejs#588

As a side note, CircleCI is currently on node 10.12 while Bazel is on node 10.9 which. We could update both to 10.13 at this point (node_repositories() has no definition for 10.12 and its not mirrored).

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@gregmagolan gregmagolan requested review from a team as code owners March 14, 2019 18:09
@gregmagolan gregmagolan added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Mar 14, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 14, 2019
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message mentions Node but the actual change is for yarn?

Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment that the principled answer is blocked on bazelbuild/rules_nodejs#588 ?

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Mar 14, 2019
@matsko matsko closed this in 6ab8c0b Mar 14, 2019
alexeagle added a commit to alexeagle/angular that referenced this pull request Mar 15, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants