Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): update bazel managed yarn to 1.13.0 (same as CI version) #29311

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@gregmagolan
Copy link
Contributor

gregmagolan commented Mar 14, 2019

This PR updates bazel managed yarn.

Note: we tried using vendored_yarn previously but this caused major issues on Windows: bazelbuild/rules_nodejs#588

As a side note, CircleCI is currently on node 10.12 while Bazel is on node 10.9 which. We could update both to 10.13 at this point (node_repositories() has no definition for 10.12 and its not mirrored).

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@gregmagolan gregmagolan requested review from angular/fw-dev-infra as code owners Mar 14, 2019

@googlebot googlebot added the cla: yes label Mar 14, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 14, 2019

@kyliau

kyliau approved these changes Mar 14, 2019

@kyliau
Copy link
Member

kyliau left a comment

the commit message mentions Node but the actual change is for yarn?

@alexeagle
Copy link
Contributor

alexeagle left a comment

maybe add a comment that the principled answer is blocked on bazelbuild/rules_nodejs#588 ?

@matsko matsko closed this in 6ab8c0b Mar 14, 2019

alexeagle added a commit to alexeagle/angular that referenced this pull request Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.