fix(ivy): add temporary hack for deprecatedOverrideProvider #29324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
force-pushed
the
deprecatedOverrideProvider
branch
from
c9126ce
to
b59a3d3
Compare
kara
added
action: review
HACK: This is NOT the correct implementation for deprecatedOverrideProvider. We do not plan to implement this at all since the API is deprecated and scheduled for removal in V8. This hack is here temporarily for Ivy testing until we transition apps inside Google to the overrideProvider API. At that point, we will be able to remove this method entirely. In the meantime, we can use overrideProvider here to test apps with Ivy that don't care about eager instantiation. This fixes 97% of cases in our blueprint.
kara
force-pushed
the
deprecatedOverrideProvider
branch
from
b59a3d3
to
512d9a5
Compare
mhevery
approved these changes
Mar 15, 2019
kara
added
action: merge
alxhub
approved these changes
Mar 15, 2019
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…29324) HACK: This is NOT the correct implementation for deprecatedOverrideProvider. We do not plan to implement this at all since the API is deprecated and scheduled for removal in V8. This hack is here temporarily for Ivy testing until we transition apps inside Google to the overrideProvider API. At that point, we will be able to remove this method entirely. In the meantime, we can use overrideProvider here to test apps with Ivy that don't care about eager instantiation. This fixes 97% of cases in our blueprint. PR Close angular#29324
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HACK: This is NOT the correct implementation for deprecatedOverrideProvider.
We do not plan to implement this at all since the API is deprecated and
scheduled for removal in V8. This hack is here temporarily for Ivy testing
until we transition apps inside Google to the overrideProvider API. At that
point, we will be able to remove this method entirely. In the meantime, we
can use overrideProvider here to test apps with Ivy that don't care about
eager instantiation. This fixes 85% of cases in our blueprint.