fix(ivy): listeners inherited twice if sub class has own propMetadata #29353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes host listeners being inherited twice, if the sub class has its own `propMetadata`. This is related to angular#29170 which fixed something similar, however all of the test cases there had a super class with some metadata and a sub class that didn't have any. The issue manifested itself in the `MatTreeToggle` which inherits a listener from the `CdkTreeToggle` and adds an extra `Input` of its own, causing the listener to be added twice.
crisbeto
force-pushed
the
host-listener-twice-prop-metadata
branch
from
082458a
to
b839385
Compare
crisbeto
added
type: bug/fix
action: review
kara
added
target: major
kara
added
action: merge
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…angular#29353) Fixes host listeners being inherited twice, if the sub class has its own `propMetadata`. This is related to angular#29170 which fixed something similar, however all of the test cases there had a super class with some metadata and a sub class that didn't have any. The issue manifested itself in the `MatTreeToggle` which inherits a listener from the `CdkTreeToggle` and adds an extra `Input` of its own, causing the listener to be added twice. PR Close angular#29353
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes host listeners being inherited twice, if the sub class has its own
propMetadata. This is related to #29170 which fixed something similar, however all of the test cases there had a super class with some metadata and a sub class that didn't have any. The issue manifested itself in theMatTreeTogglewhich inherits a listener from theCdkTreeToggleand adds an extraInputof its own, causing the listener to be added twice.