-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): inherited host listeners called twice #29170
Closed
crisbeto
wants to merge
1
commit into
angular:master
from
crisbeto:FW-1142/host-listener-double-inheritance
Closed
fix(ivy): inherited host listeners called twice #29170
crisbeto
wants to merge
1
commit into
angular:master
from
crisbeto:FW-1142/host-listener-double-inheritance
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
FW-1142/host-listener-double-inheritance
branch
from
March 7, 2019 20:41
1c3d03b
to
3dcc802
Compare
Fixes host listeners being inherited twice when going through `setClassMetadata`. This PR resolves FW-1142.
crisbeto
force-pushed
the
FW-1142/host-listener-double-inheritance
branch
from
March 8, 2019 17:21
3dcc802
to
35bd73f
Compare
crisbeto
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
type: bug/fix
labels
Mar 8, 2019
kara
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kara
added
action: presubmit
The PR is in need of a google3 presubmit
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Mar 8, 2019
kara
added
action: merge
The PR is ready for merge by the caretaker
target: major
This PR is targeted for the next major release
and removed
action: presubmit
The PR is in need of a google3 presubmit
labels
Mar 8, 2019
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Mar 16, 2019
Fixes host listeners being inherited twice, if the sub class has its own `propMetadata`. This is related to angular#29170 which fixed something similar, however all of the test cases there had a super class with some metadata and a sub class that didn't have any. The issue manifested itself in the `MatTreeToggle` which inherits a listener from the `CdkTreeToggle` and adds an extra `Input` of its own, causing the listener to be added twice.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Mar 16, 2019
Fixes host listeners being inherited twice, if the sub class has its own `propMetadata`. This is related to angular#29170 which fixed something similar, however all of the test cases there had a super class with some metadata and a sub class that didn't have any. The issue manifested itself in the `MatTreeToggle` which inherits a listener from the `CdkTreeToggle` and adds an extra `Input` of its own, causing the listener to be added twice.
jasonaden
pushed a commit
that referenced
this pull request
Mar 18, 2019
…#29353) Fixes host listeners being inherited twice, if the sub class has its own `propMetadata`. This is related to #29170 which fixed something similar, however all of the test cases there had a super class with some metadata and a sub class that didn't have any. The issue manifested itself in the `MatTreeToggle` which inherits a listener from the `CdkTreeToggle` and adds an extra `Input` of its own, causing the listener to be added twice. PR Close #29353
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
Fixes host listeners being inherited twice when going through `setClassMetadata`. This PR resolves FW-1142. PR Close angular#29170
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…angular#29353) Fixes host listeners being inherited twice, if the sub class has its own `propMetadata`. This is related to angular#29170 which fixed something similar, however all of the test cases there had a super class with some metadata and a sub class that didn't have any. The issue manifested itself in the `MatTreeToggle` which inherits a listener from the `CdkTreeToggle` and adds an extra `Input` of its own, causing the listener to be added twice. PR Close angular#29353
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
target: major
This PR is targeted for the next major release
type: bug/fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes host listeners being inherited twice when going through
setClassMetadata
.This PR resolves FW-1142.