fix(ivy): ngtsc is unable to detect flat module entry-point on windows #29453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Mar 21, 2019
devversion
commented
- See individual commits
devversion
added
action: review
devversion
force-pushed
the
fix/ivy-flat-module-windows
branch
from
dbc3613
to
837064a
Compare
gkalpak
reviewed
Mar 22, 2019
devversion
force-pushed
the
fix/ivy-flat-module-windows
branch
from
837064a
to
5a21d0b
Compare
alxhub
approved these changes
Mar 26, 2019
Currently when building an Angular project with `ngtsc` and `flatModuleOutFile` enabled, the Ngtsc build will fail if there are multiple source files as root file names. Ngtsc and NGC currently determine the entry-point for multiple root file names by looking for files ending with `/index.ts`. This functionality is technically deprecated, but still supported and currently breaks on Windows as the root file names are not guaranteed to be normalized POSIX-like paths. In order to make this logic more reliable in the future, this commit also switches the shim generators and entry-point logic to the branded path types. This ensures that we don't break this in the future.
devversion
force-pushed
the
fix/ivy-flat-module-windows
branch
from
5a21d0b
to
475f08e
Compare
devversion
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
Caretaker note: Please merge assistance because |
mhevery
pushed a commit
that referenced
this pull request
Mar 27, 2019
#29453) Currently when building an Angular project with `ngtsc` and `flatModuleOutFile` enabled, the Ngtsc build will fail if there are multiple source files as root file names. Ngtsc and NGC currently determine the entry-point for multiple root file names by looking for files ending with `/index.ts`. This functionality is technically deprecated, but still supported and currently breaks on Windows as the root file names are not guaranteed to be normalized POSIX-like paths. In order to make this logic more reliable in the future, this commit also switches the shim generators and entry-point logic to the branded path types. This ensures that we don't break this in the future. PR Close #29453
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
angular#29453) Currently when building an Angular project with `ngtsc` and `flatModuleOutFile` enabled, the Ngtsc build will fail if there are multiple source files as root file names. Ngtsc and NGC currently determine the entry-point for multiple root file names by looking for files ending with `/index.ts`. This functionality is technically deprecated, but still supported and currently breaks on Windows as the root file names are not guaranteed to be normalized POSIX-like paths. In order to make this logic more reliable in the future, this commit also switches the shim generators and entry-point logic to the branded path types. This ensures that we don't break this in the future. PR Close angular#29453
| @@ -60,14 +61,16 @@ export class GeneratedShimsHostWrapper implements ts.CompilerHost { | |||
| shouldCreateNewSourceFile?: boolean|undefined): ts.SourceFile|undefined { | |||
| for (let i = 0; i < this.shimGenerators.length; i++) { | |||
| const generator = this.shimGenerators[i]; | |||
| if (generator.recognize(fileName)) { | |||
| // TypeScript internal paths are guaranteed to be POSIX-like absolute file paths. | |||
| const absoluteFsPath = AbsoluteFsPath.fromUnchecked(fileName); | |||
There was a problem hiding this comment.
It turns out (at least in tests) that it is not true that fileName is always absolute. Changing this to AbsoluteFsPath.from() causes lots of test failures such as:
193) compiler compliance: listen() should create declare inputs/outputs
Message:
Error: Internal Error: AbsoluteFsPath.from(lib.d.ts): path is not absolute
Stack:
Error: Internal Error: AbsoluteFsPath.from(lib.d.ts): path is not absolute
at Object.from (packages/compiler-cli/src/ngtsc/path/src/types.ts:59:13)
at GeneratedShimsHostWrapper.getSourceFile (packages/compiler-cli/src/ngtsc/shims/src/host.ts:76:45)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.