Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): ngtsc is unable to detect flat module entry-point on windows #29453

Closed
wants to merge 2 commits into from
Closed

fix(ivy): ngtsc is unable to detect flat module entry-point on windows #29453

wants to merge 2 commits into from

Commits on Mar 26, 2019

  1. refactor(ivy): fix incorrect error message in ngtsc "PathSegment"

    @devversion
    devversion committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    c70be62 View commit details
    Browse the repository at this point in the history

  2. fix(ivy): ngtsc is unable to detect flat module entry-point on windows 

    Currently when building an Angular project with `ngtsc`
and `flatModuleOutFile` enabled, the Ngtsc build will fail
if there are multiple source files as root file names.

Ngtsc and NGC currently determine the entry-point for multiple
root file names by looking for files ending with `/index.ts`.

This functionality is technically deprecated, but still supported
and currently breaks on Windows as the root file names are not
guaranteed to be normalized POSIX-like paths.

In order to make this logic more reliable in the future, this commit
also switches the shim generators and entry-point logic to the branded
path types. This ensures that we don't break this in the future.
    @devversion
    devversion committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    475f08e View commit details
    Browse the repository at this point in the history