Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): typings template should make module name at end of file dynamic #2948

Closed
jeffbcross opened this issue Jul 9, 2015 · 2 comments

Comments

@jeffbcross
Copy link
Contributor

This template is causing the router.d.ts output to have a redundant declaration to angular2.

declare module "angular2/angular2" {
  export ng;
}

Should be

declare module "angular2/router" {
  export = ng;
}

Template location: https://github.com/angular/angular/blob/master/docs/dgeni-package/templates/type-definition.template.html

@jeffbcross
Copy link
Contributor Author

Also, the namespace should be dynamic, i.e. ngRouter, as described in #3458.

@jeffbcross jeffbcross self-assigned this Aug 7, 2015
@jeffbcross jeffbcross added this to the alpha-35 milestone Aug 7, 2015
jeffbcross added a commit to jeffbcross/angular that referenced this issue Aug 8, 2015
Allows declaring a bundle's namespace in generated typings file,
which should correspond to the global object representing the module
inside its bundle.

BREAKING CHANGE
    The router was previously exported as ng.router in the 
    angular.sfx.dev.js bundle, but now it is exported as ngRouter.

Closes angular#2948
jeffbcross added a commit to jeffbcross/angular that referenced this issue Aug 8, 2015
Allows declaring a bundle's namespace in generated typings file,
which should correspond to the global object representing the module
inside its bundle.

BREAKING CHANGE
    The router was previously exported as ng.router in the 
    angular.sfx.dev.js bundle, but now it is exported as ngRouter.

Closes angular#2948
jeffbcross added a commit to jeffbcross/angular that referenced this issue Aug 8, 2015
Allows declaring a bundle's namespace in generated typings file,
which should correspond to the global object representing the module
inside its bundle.

BREAKING CHANGE
    The router was previously exported as ng.router in the 
    angular.sfx.dev.js bundle, but now it is exported as ngRouter.

Closes angular#2948
jeffbcross added a commit to jeffbcross/angular that referenced this issue Aug 10, 2015
Allows declaring a bundle's namespace in generated typings file,
which should correspond to the global object representing the module
inside its bundle.

BREAKING CHANGE
    The router was previously exported as ng.router in the 
    angular.sfx.dev.js bundle, but now it is exported as ngRouter.

Closes angular#2948
goderbauer pushed a commit to goderbauer/angular that referenced this issue Aug 15, 2015
Allows declaring a bundle's namespace in generated typings file,
which should correspond to the global object representing the module
inside its bundle.

BREAKING CHANGE
    The router was previously exported as ng.router in the 
    angular.sfx.dev.js bundle, but now it is exported as ngRouter.

Closes angular#2948

Closes angular#3544
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants