-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typings): typings template should make module name at end of file dynamic #2948
Comments
Also, the namespace should be dynamic, i.e. ngRouter, as described in #3458. |
13 tasks
jeffbcross
added a commit
to jeffbcross/angular
that referenced
this issue
Aug 8, 2015
Allows declaring a bundle's namespace in generated typings file, which should correspond to the global object representing the module inside its bundle. BREAKING CHANGE The router was previously exported as ng.router in the angular.sfx.dev.js bundle, but now it is exported as ngRouter. Closes angular#2948
jeffbcross
added a commit
to jeffbcross/angular
that referenced
this issue
Aug 8, 2015
Allows declaring a bundle's namespace in generated typings file, which should correspond to the global object representing the module inside its bundle. BREAKING CHANGE The router was previously exported as ng.router in the angular.sfx.dev.js bundle, but now it is exported as ngRouter. Closes angular#2948
jeffbcross
added a commit
to jeffbcross/angular
that referenced
this issue
Aug 8, 2015
Allows declaring a bundle's namespace in generated typings file, which should correspond to the global object representing the module inside its bundle. BREAKING CHANGE The router was previously exported as ng.router in the angular.sfx.dev.js bundle, but now it is exported as ngRouter. Closes angular#2948
jeffbcross
added a commit
to jeffbcross/angular
that referenced
this issue
Aug 10, 2015
Allows declaring a bundle's namespace in generated typings file, which should correspond to the global object representing the module inside its bundle. BREAKING CHANGE The router was previously exported as ng.router in the angular.sfx.dev.js bundle, but now it is exported as ngRouter. Closes angular#2948
goderbauer
pushed a commit
to goderbauer/angular
that referenced
this issue
Aug 15, 2015
Allows declaring a bundle's namespace in generated typings file, which should correspond to the global object representing the module inside its bundle. BREAKING CHANGE The router was previously exported as ng.router in the angular.sfx.dev.js bundle, but now it is exported as ngRouter. Closes angular#2948 Closes angular#3544
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This template is causing the router.d.ts output to have a redundant declaration to angular2.
Should be
Template location: https://github.com/angular/angular/blob/master/docs/dgeni-package/templates/type-definition.template.html
The text was updated successfully, but these errors were encountered: