ngcc - some SourceMap URLs are incorrect #29556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and Renderer We have already removed this concept from the public API. This just cleans it out altogether. The `targetPath` was an alternative output path to the original `basePath`. This is not really a very useful concept, since the actual target path of each output file is more complex and not consistently relative to the `basePath`.
Previously we were using absolute paths, but since at rendering time we do not know exactly where the file will be written it is more correct to change to using relative paths. This is actually better all round since it allows the folders to be portable to different machines, etc.
Previously we were writing `.d.ts` and `.d.ts.map` to different folders.
petebacondarwin
added
area: core
alxhub
approved these changes
Mar 27, 2019
petebacondarwin
added
target: major
gkalpak
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Not directly related to this PR, but the docs for Renderer#renderFile() out outdated (and mention targetPath).
jasonaden
pushed a commit
that referenced
this pull request
Mar 28, 2019
Previously we were using absolute paths, but since at rendering time we do not know exactly where the file will be written it is more correct to change to using relative paths. This is actually better all round since it allows the folders to be portable to different machines, etc. PR Close #29556
jasonaden
pushed a commit
that referenced
this pull request
Mar 28, 2019
Previously we were writing `.d.ts` and `.d.ts.map` to different folders. PR Close #29556
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…er and Renderer (angular#29556) We have already removed this concept from the public API. This just cleans it out altogether. The `targetPath` was an alternative output path to the original `basePath`. This is not really a very useful concept, since the actual target path of each output file is more complex and not consistently relative to the `basePath`. PR Close angular#29556
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…ar#29556) Previously we were using absolute paths, but since at rendering time we do not know exactly where the file will be written it is more correct to change to using relative paths. This is actually better all round since it allows the folders to be portable to different machines, etc. PR Close angular#29556
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…ar#29556) Previously we were writing `.d.ts` and `.d.ts.map` to different folders. PR Close angular#29556
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// FW-1197