Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngcc - some SourceMap URLs are incorrect #29556

Closed
wants to merge 3 commits into from
Closed

ngcc - some SourceMap URLs are incorrect #29556

wants to merge 3 commits into from

Commits on Mar 27, 2019

  1. refactor(ivy): ngcc - remove the targetPath properties of Transform… 

    …er and Renderer

We have already removed this concept from the public API. This just cleans it out altogether.

The `targetPath` was an alternative output path to the original `basePath`.
This is not really a very useful concept, since the actual target path
of each output file is more complex and not consistently relative to the `basePath`.
    @petebacondarwin
    petebacondarwin committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    0c58db3 View commit details
    Browse the repository at this point in the history

  2. fix(ivy): ngcc - ensure generated source map paths are correct 

    Previously we were using absolute paths, but since at rendering time
we do not know exactly where the file will be written it is more correct
to  change to using relative paths. This is actually better all round
since it allows the folders to be portable to different machines, etc.
    @petebacondarwin
    petebacondarwin committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    5016c8b View commit details
    Browse the repository at this point in the history

  3. fix(ivy): ngcc - write .d.ts.map files to the correct folder 

    Previously we were writing `.d.ts` and `.d.ts.map` to different
folders.
    @petebacondarwin
    petebacondarwin committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    a59de54 View commit details
    Browse the repository at this point in the history