Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix CODEOWNERS for ngcc #29660

Closed
wants to merge 1 commit into from
Closed

ci: fix CODEOWNERS for ngcc #29660

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Apr 2, 2019

With a770aa2, ngcc was moved to a different directory (compiler/src/ngcc/ --> compiler/ngcc/), but the CODEOWNERS file was not updated to reflect that.

@gkalpak
ci: fix CODEOWNERS for ngcc
7ac2b04 
With a770aa2, ngcc was moved to a different directory
(`compiler/src/ngcc/` --> `compiler/ngcc/`), but the `CODEOWNERS` file
was not updated to reflect that.
@gkalpak gkalpak requested a review from IgorMinar as a code owner April 2, 2019 12:36
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release comp: ivy labels Apr 2, 2019
@ngbot ngbot bot modified the milestone: needsTriage Apr 2, 2019
@gkalpak gkalpak mentioned this pull request Apr 2, 2019
Closed
14 tasks
@jasonaden jasonaden closed this in c579949 Apr 2, 2019
@gkalpak gkalpak deleted the ci-ngcc-update-codeowners branch April 3, 2019 09:51
@gkalpak gkalpak mentioned this pull request Apr 3, 2019
Closed
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
@gkalpak @DeveloperFromUkraine
ci: fix CODEOWNERS for ngcc (angular#29660)
8637767 
With a770aa2, ngcc was moved to a different directory
(`compiler/src/ngcc/` --> `compiler/ngcc/`), but the `CODEOWNERS` file
was not updated to reflect that.
PR Close angular#29660
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@gkalpak @wKoza
ci: fix CODEOWNERS for ngcc (angular#29660)
d5c9650 
With a770aa2, ngcc was moved to a different directory
(`compiler/src/ngcc/` --> `compiler/ngcc/`), but the `CODEOWNERS` file
was not updated to reflect that.
PR Close angular#29660
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkalpak @petebacondarwin @googlebot