Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): remove karma-jasmine from ts_web_test_suite #29695

Closed
wants to merge 1 commit into from
Closed

fix(bazel): remove karma-jasmine from ts_web_test_suite #29695

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 4, 2019 •
edited

karma-jasmine dep is unnecessary and has no effect.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from a team as a code owner April 4, 2019 00:31
@kyliau kyliau added area: bazel Issues related to the published `@angular/bazel` build rules target: major This PR is targeted for the next major release and removed cla: yes labels Apr 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 4, 2019
@kyliau kyliau changed the title remove karma-jasmine from ts_web_test_suite fix(bazel): remove karma-jasmine from ts_web_test_suite Apr 4, 2019
@kyliau kyliau requested a review from gregmagolan April 4, 2019 00:57
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Apr 4, 2019
@IgorMinar IgorMinar closed this in 2bd9214 Apr 4, 2019
@kyliau kyliau deleted the karma branch April 4, 2019 23:42
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
@kyliau @DeveloperFromUkraine
fix(bazel): remove karma-jasmine from ts_web_test_suite (angular#29695)
cb736f1 
It's not needed.

PR Close angular#29695
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@kyliau @wKoza
fix(bazel): remove karma-jasmine from ts_web_test_suite (angular#29695)
496249d 
It's not needed.

PR Close angular#29695
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyliau @gregmagolan @googlebot