build(docs-infra): upgrade lighthouse and list missing dependencies #29904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, log the Lighthouse version in `test-pwa-score` to aid in debugging.
…use-logger) We are using `chrome-launcher` and `lighthouse-logger` in [test-pwa-score][1], but we do not explicitly list them as `devDependencies`, so we are relying on the fact that they happen to be hoisted in `node_modules/` by yarn. This may unexpectedly break in the future. This commit fixes this, by explicitly listing them as `devDependencies`. [1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18
gkalpak
added
action: merge
|
You can preview e0b0ecd at https://pr29904-e0b0ecd.ngbuilds.io/. |
alxhub
pushed a commit
that referenced
this pull request
Apr 15, 2019
…use-logger) (#29904) We are using `chrome-launcher` and `lighthouse-logger` in [test-pwa-score][1], but we do not explicitly list them as `devDependencies`, so we are relying on the fact that they happen to be hoisted in `node_modules/` by yarn. This may unexpectedly break in the future. This commit fixes this, by explicitly listing them as `devDependencies`. [1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18 PR Close #29904
alxhub
pushed a commit
that referenced
this pull request
Apr 15, 2019
Also, log the Lighthouse version in `test-pwa-score` to aid in debugging. PR Close #29904
alxhub
pushed a commit
that referenced
this pull request
Apr 15, 2019
…use-logger) (#29904) We are using `chrome-launcher` and `lighthouse-logger` in [test-pwa-score][1], but we do not explicitly list them as `devDependencies`, so we are relying on the fact that they happen to be hoisted in `node_modules/` by yarn. This may unexpectedly break in the future. This commit fixes this, by explicitly listing them as `devDependencies`. [1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18 PR Close #29904
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
Also, log the Lighthouse version in `test-pwa-score` to aid in debugging. PR Close angular#29904
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…use-logger) (angular#29904) We are using `chrome-launcher` and `lighthouse-logger` in [test-pwa-score][1], but we do not explicitly list them as `devDependencies`, so we are relying on the fact that they happen to be hoisted in `node_modules/` by yarn. This may unexpectedly break in the future. This commit fixes this, by explicitly listing them as `devDependencies`. [1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18 PR Close angular#29904
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
build(docs-infra): upgrade lighthouse to 4.3.0
Also, log the Lighthouse version in
test-pwa-scoreto aid in debugging.build(docs-infra): add missing dependencies (chrome-launcher, lighthouse-logger)
We are using
chrome-launcherandlighthouse-loggerin test-pwa-score, but we do not explicitly list them asdevDependencies, so we are relying on the fact that they happen to be hoisted innode_modules/by yarn. This may unexpectedly break in the future.This commit fixes this, by explicitly listing them as
devDependencies.