Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): DebugNode.properties not preserving type of values #29914

Closed
wants to merge 1 commit into from
Closed

fix(ivy): DebugNode.properties not preserving type of values #29914

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes the DebugNode.properties casting all of the values to a string.

This PR resolves FW-1253.

@crisbeto
fix(ivy): DebugNode.properties not preserving type of values
106a62d 
Fixes the `DebugNode.properties` casting all of the values to a string.

This PR resolves FW-1253.
@crisbeto crisbeto force-pushed the FW-1253/debug-node-prop-values branch from 497c935 to 106a62d Compare April 15, 2019 20:11
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 15, 2019
@crisbeto crisbeto marked this pull request as ready for review April 15, 2019 20:23
@crisbeto crisbeto requested a review from a team as a code owner April 15, 2019 20:23
kara
kara approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added comp: ivy target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 15, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 15, 2019
@kara kara added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker labels Apr 15, 2019
@kara
Copy link
Contributor

kara commented Apr 15, 2019 •
edited

presubmit

@kara kara removed the action: presubmit The PR is in need of a google3 presubmit label Apr 16, 2019
@alxhub alxhub closed this in 5d824c4 Apr 16, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@crisbeto @wKoza
fix(ivy): DebugNode.properties not preserving type of values (angular…
e1d2683 
…#29914)

Fixes the `DebugNode.properties` casting all of the values to a string.

This PR resolves FW-1253.

PR Close angular#29914
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @kara @googlebot