Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtoView should precompute number of local variables #300

Closed
mhevery opened this issue Dec 11, 2014 · 3 comments
Closed

ProtoView should precompute number of local variables #300

mhevery opened this issue Dec 11, 2014 · 3 comments
Assignees

Comments

@mhevery
Copy link
Contributor

mhevery commented Dec 11, 2014

Each View iterates over local variables to determine if there are any. See

if (MapWrapper.size(protoContextLocals) > 0) {
such information should be precompeted in the ProtoView and cached.

@mhevery mhevery added this to the Performance Optimization milestone Dec 11, 2014
@tbosch
Copy link
Contributor

tbosch commented Dec 12, 2014

It's just a size check, no iteration....

On Thu Dec 11 2014 at 2:18:35 PM Miško Hevery notifications@github.com
wrote:

Each View iterates over local variables to determine if there are any.
See

if (MapWrapper.size(protoContextLocals) > 0) {

such information should be precompeted in the ProtoView and cached.


Reply to this email directly or view it on GitHub
#300.

@mhevery
Copy link
Contributor Author

mhevery commented May 29, 2015

its already fixed in different way

@mhevery mhevery closed this as completed May 29, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants