test(upgrade): rename angular.module() to angular.module_()
#30126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With angular#30058, the ngUpgrade internal `angular.module()` method was renamed to `angular.module_()` (to avoid a webpack bug). Merging angular#29794 afterwards resulted in some broken tests, because it still used the old `angular.module()` method name. (The PR had been tested on CI against a revision that did not contain the rename.) This commit fixes the broken tests by renaming the remaining occurrences of `angular.module()`.
gkalpak
added
area: upgrade
6 tasks
|
You can preview ee50fd9 at https://pr30126-ee50fd9.ngbuilds.io/. |
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…lar#30126) With angular#30058, the ngUpgrade internal `angular.module()` method was renamed to `angular.module_()` (to avoid a webpack bug). Merging angular#29794 afterwards resulted in some broken tests, because it still used the old `angular.module()` method name. (The PR had been tested on CI against a revision that did not contain the rename.) This commit fixes the broken tests by renaming the remaining occurrences of `angular.module()`. PR Close angular#30126
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #30058, the ngUpgrade internal
angular.module()method was renamed toangular.module_()(to avoid a webpack bug).Merging #29794 afterwards resulted in some broken tests, because it still used the old
angular.module()method name. (The PR had been tested on CI against a revision that did not contain the rename.)This commit fixes the broken tests by renaming the remaining occurrences of
angular.module().I have also incorporated the changes in #30107 for 7.2.x.