refactor(upgrade): rename module constant to avoid webpack bug
#30058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
area: upgrade
|
|
|
You can preview f73d431 at https://pr30058-f73d431.ngbuilds.io/. |
When targeting ES2015 (as is the default in cli@8), `const` is not downleveled to `var` and thus declaring `const module` throws an error due to webpack wrapping the code in a function call with a `module` argument (even when compiling for the `web` environment). Related: webpack/webpack#7369 Fixes angular#30050
gkalpak
force-pushed
the
refactor-upgrade-rename-module
branch
from
f73d431
to
d97a8b7
Compare
|
You can preview d97a8b7 at https://pr30058-d97a8b7.ngbuilds.io/. |
benlesh
added
the
action: review
IgorMinar
approved these changes
Apr 24, 2019
|
Hopefully 😅 |
|
But wouldn't this be a problem in a node environment if the webpack bug is fixed for the web environment? I'm thinking Angular Universal |
gkalpak
removed
the
action: review
|
Presubmit, rerun due to flakes. |
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
removed
the
action: presubmit
IgorMinar
added
the
merge: caretaker note
|
merge-assistance: g3 failure looks like a flake |
AndrewKushnir
removed
the
target: patch
AndrewKushnir
added
the
target: major
|
@gkalpak merging to patch branch failed due to conflicts, so I merged this PR to master only. Could you please create a separate PR and target patch branch? Thank you. |
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 25, 2019
…ular#30058) When targeting ES2015 (as is the default in cli@8), `const` is not downleveled to `var` and thus declaring `const module` throws an error due to webpack wrapping the code in a function call with a `module` argument (even when compiling for the `web` environment). Related: webpack/webpack#7369 Fixes angular#30050 PR Close angular#30058
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 25, 2019
…ular#30058) When targeting ES2015 (as is the default in cli@8), `const` is not downleveled to `var` and thus declaring `const module` throws an error due to webpack wrapping the code in a function call with a `module` argument (even when compiling for the `web` environment). Related: webpack/webpack#7369 Fixes angular#30050 PR Close angular#30058
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 25, 2019
…ular#30058) When targeting ES2015 (as is the default in cli@8), `const` is not downleveled to `var` and thus declaring `const module` throws an error due to webpack wrapping the code in a function call with a `module` argument (even when compiling for the `web` environment). Related: webpack/webpack#7369 Fixes angular#30050 PR Close angular#30058
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 25, 2019
With angular#30058, the ngUpgrade internal `angular.module()` method was renamed to `angular.module_()` (to avoid a webpack bug). Merging angular#29794 afterwards resulted in some broken tests, because it still used the old `angular.module()` method name. (The PR had been tested on CI against a revision that did not contain the rename.) This commit fixes the broken tests by renaming the remaining occurrences of `angular.module()`.
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 25, 2019
With angular#30058, the ngUpgrade internal `angular.module()` method wa renamed to `angular.module_()` (to avoid a webpack bug). Merging angular#29794 afterwards resulted in some broken tests, because it still used the old `angular.module()` method name. (The PR had been tested on CI against a revision that did not contain the rename.) This commit fixes the broken tests by renaming the remaining occurrences of `angular.module()`.
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2019
With #30058, the ngUpgrade internal `angular.module()` method was renamed to `angular.module_()` (to avoid a webpack bug). Merging #29794 afterwards resulted in some broken tests, because it still used the old `angular.module()` method name. (The PR had been tested on CI against a revision that did not contain the rename.) This commit fixes the broken tests by renaming the remaining occurrences of `angular.module()`. PR Close #30126
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2019
) (#30107) When targeting ES2015 (as is the default in cli@8), `const` is not downleveled to `var` and thus declaring `const module` throws an error due to webpack wrapping the code in a function call with a `module` argument (even when compiling for the `web` environment). Related: webpack/webpack#7369 Fixes #30050 PR Close #30058 PR Close #30107
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2019
With #30058, the ngUpgrade internal `angular.module()` method wa renamed to `angular.module_()` (to avoid a webpack bug). Merging #29794 afterwards resulted in some broken tests, because it still used the old `angular.module()` method name. (The PR had been tested on CI against a revision that did not contain the rename.) This commit fixes the broken tests by renaming the remaining occurrences of `angular.module()`. PR Close #30107
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ular#30058) When targeting ES2015 (as is the default in cli@8), `const` is not downleveled to `var` and thus declaring `const module` throws an error due to webpack wrapping the code in a function call with a `module` argument (even when compiling for the `web` environment). Related: webpack/webpack#7369 Fixes angular#30050 PR Close angular#30058
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…lar#30126) With angular#30058, the ngUpgrade internal `angular.module()` method was renamed to `angular.module_()` (to avoid a webpack bug). Merging angular#29794 afterwards resulted in some broken tests, because it still used the old `angular.module()` method name. (The PR had been tested on CI against a revision that did not contain the rename.) This commit fixes the broken tests by renaming the remaining occurrences of `angular.module()`. PR Close angular#30126
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting ES2015 (as is the default in cli@8),
constis not downleveled tovarand thus declaringconst modulethrows an error due to webpack wrapping the code in a function call with amoduleargument (even when compiling for thewebenvironment).Related: webpack/webpack#7369
Fixes #30050.