fix(ivy): unable to bind SafeStyle as camel case property #30328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
FW-1279/camel-case-styles
branch
from
ec456fa
to
8c73faa
Compare
Fixes not being able to bind a `SafeStyle` as a camel cased style property (e.g. `[style.backgroundImage]="someSafeStyle"`). The issue was due to the fact that we only check the dash case property names to determine whether to sanitize a value. This PR resolves FW-1279.
crisbeto
force-pushed
the
FW-1279/camel-case-styles
branch
from
8c73faa
to
c3c97b6
Compare
crisbeto
added
comp: ivy
action: review
alxhub
approved these changes
May 8, 2019
kara
added
action: merge
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
) Fixes not being able to bind a `SafeStyle` as a camel cased style property (e.g. `[style.backgroundImage]="someSafeStyle"`). The issue was due to the fact that we only check the dash case property names to determine whether to sanitize a value. This PR resolves FW-1279. PR Close angular#30328
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not being able to bind a
SafeStyleas a camel cased style property (e.g.[style.backgroundImage]="someSafeStyle"). The issue was due to the fact that we only check the dash case property names to determine whether to sanitize a value.This PR resolves FW-1279.