Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): move render3 view_container_ref tests to acceptance #30488

Closed
wants to merge 2 commits into from
Closed

test(ivy): move render3 view_container_ref tests to acceptance #30488

wants to merge 2 commits into from

Conversation

devversion
Copy link
Member

Moves all manual render3 view_container_ref tests that use property
bindings to acceptance tests with TestBed.

Two issues surfaced and refer to a difference between Ivy and View
engine:

  • Multi-slot projection is not working with Ivy: FW-1331
  • ViewContainerRef throws if index is invalid while View Engine clamped index: FW-1330

@devversion devversion force-pushed the test/ivy-move-view-container-tests-acceptance branch from 064249d to 0c9e0f3 Compare May 15, 2019 17:31
@devversion devversion added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels May 16, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 16, 2019
@devversion devversion marked this pull request as ready for review May 16, 2019 15:38
@devversion devversion requested a review from a team as a code owner May 16, 2019 15:38
kara
kara requested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, but 2 things:

  1. Need a comment on the regex

  2. It looks like there are still some tests in the render3 spec with textBinding instructions in them. These will need to be migrated as well.

packages/core/test/acceptance/view_container_ref_spec.ts Show resolved Hide resolved
@kara kara assigned devversion and unassigned kara May 17, 2019
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 17, 2019
@devversion devversion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 17, 2019
@devversion devversion force-pushed the test/ivy-move-view-container-tests-acceptance branch from b2e02df to 72a8cc8 Compare May 17, 2019 10:07
@devversion devversion added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels May 17, 2019
@devversion
test(ivy): move render3 view_container_ref tests to acceptance
8738a00 
Moves all manual render3 view_container_ref tests that use property
bindings to acceptance tests with TestBed.

Two issues surfaced and refer to a difference between Ivy and View
engine:

* Multi-slot projection is not working with Ivy: FW-1331
* ViewContainerRef throws if index is invalid while View Engine clamped index: FW-1330
@devversion
fixup! test(ivy): move render3 view_container_ref tests to acceptance
d60d045 
Convert tests with text binding instruction
@devversion devversion force-pushed the test/ivy-move-view-container-tests-acceptance branch from 72a8cc8 to d60d045 Compare May 17, 2019 11:34
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: presubmit The PR is in need of a google3 presubmit action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 17, 2019
kara
kara approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonaden jasonaden closed this in 8e2e9dc May 17, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@devversion @BioPhoton
test(ivy): move render3 view_container_ref tests to acceptance (angul…
517fb87 
…ar#30488)

Moves all manual render3 view_container_ref tests that use property
bindings to acceptance tests with TestBed.

Two issues surfaced and refer to a difference between Ivy and View
engine:

* Multi-slot projection is not working with Ivy: FW-1331
* ViewContainerRef throws if index is invalid while View Engine clamped index: FW-1330

PR Close angular#30488
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devversion @kara @googlebot