Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): move render3 view_container_ref tests to acceptance #30488

Closed
wants to merge 2 commits into from
Closed

test(ivy): move render3 view_container_ref tests to acceptance #30488

wants to merge 2 commits into from

Commits on May 17, 2019

  1. test(ivy): move render3 view_container_ref tests to acceptance 

    Moves all manual render3 view_container_ref tests that use property
bindings to acceptance tests with TestBed.

Two issues surfaced and refer to a difference between Ivy and View
engine:

* Multi-slot projection is not working with Ivy: FW-1331
* ViewContainerRef throws if index is invalid while View Engine clamped index: FW-1330
    @devversion
    devversion committed May 17, 2019
    Configuration menu
    Copy the full SHA
    8738a00 View commit details
    Browse the repository at this point in the history

  2. fixup! test(ivy): move render3 view_container_ref tests to acceptance 

    Convert tests with text binding instruction
    @devversion
    devversion committed May 17, 2019
    Configuration menu
    Copy the full SHA
    d60d045 View commit details
    Browse the repository at this point in the history