Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): correctly project bare ICU expressions #30696

Closed
wants to merge 2 commits into from
Closed

fix(ivy): correctly project bare ICU expressions #30696

wants to merge 2 commits into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented May 28, 2019

Projecting bare ICU expressions failed because we would assume that component's content nodes would be projected later and doing so at that point would be wasteful. But ICU nodes are handled independently and should be inserted immediately because they will be ignored by projections.

FW-1348 #resolve

@ocombe ocombe added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy risk: low labels May 28, 2019
@ocombe ocombe requested a review from a team as a code owner May 28, 2019 14:29
@ngbot ngbot bot added this to the needsTriage milestone May 28, 2019
AndrewKushnir
AndrewKushnir approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 On nit: it might be helpful to have a comment in the code (above updated condition), similar to what you wrote in PR description.

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 28, 2019
@AndrewKushnir
Copy link
Contributor

Presubmit

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels May 28, 2019
@ocombe ocombe added state: WIP and removed action: merge The PR is ready for merge by the caretaker labels May 30, 2019
@ocombe ocombe requested a review from AndrewKushnir May 31, 2019 14:28
@ocombe ocombe force-pushed the fix/ivy/fw-1348-project-icu branch from d4153db to 24df37d Compare May 31, 2019 14:29
@ocombe ocombe mentioned this pull request May 31, 2019
Closed
@ocombe ocombe requested a review from mhevery May 31, 2019 15:37
@ocombe ocombe mentioned this pull request May 31, 2019
Closed
AndrewKushnir
AndrewKushnir approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir
Copy link
Contributor

@ocombe could you plz look into integration_test failure (size limit needs to be updated). Thank you.

@ocombe ocombe force-pushed the fix/ivy/fw-1348-project-icu branch from 24df37d to cf70ab5 Compare June 3, 2019 12:45
@ocombe
fix(ivy): correctly project bare ICU expressions
970e5be 
Projecting bare ICU expressions failed because we would assume that component's content nodes would be projected later and doing so at that point would be wasteful. But ICU nodes are handled independently and should be inserted immediately because they will be ignored by projections.

FW-1348 #resolve
@ocombe
fixup! fix(ivy): correctly project bare ICU expressions
4d5fe97
@ocombe ocombe force-pushed the fix/ivy/fw-1348-project-icu branch from cf70ab5 to 4d5fe97 Compare June 3, 2019 13:06
@ocombe ocombe requested a review from a team as a code owner June 3, 2019 13:06
@ocombe ocombe removed the state: WIP label Jun 3, 2019
@ocombe ocombe added the action: merge The PR is ready for merge by the caretaker label Jun 3, 2019
@ocombe ocombe requested a review from mhevery June 3, 2019 13:25
@ocombe ocombe removed the action: merge The PR is ready for merge by the caretaker label Jun 3, 2019
@mhevery
Copy link
Contributor

mhevery commented Jun 3, 2019

http://test/OCL:251236135:BASE:251236170:1559575531264:9be726a8

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jun 3, 2019
@mhevery mhevery closed this in 680d385 Jun 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes risk: low target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocombe @AndrewKushnir @mhevery @googlebot