fix(ivy): don't project removed placeholders with runtime i18n #30783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
type: bug/fix
state: blocked
action: review
ocombe
changed the title
mhevery
reviewed
May 31, 2019
AndrewKushnir
approved these changes
May 31, 2019
ocombe
force-pushed
the
fix/ivy/fw-1319-i18n-project-removed-nodes
branch
from
5006e98
to
9ea1bc9
Compare
ocombe
force-pushed
the
fix/ivy/fw-1319-i18n-project-removed-nodes
branch
6 times, most recently
from
7985073
to
70feb6a
Compare
When translated content was projected, all of the content was reappended, even the placeholders that had been removed in the translation. To avoid that we added a new flag on `TNode` that specifies that a node is detached, in which case it should be ignored by the projection. FW-1319 #resolve
ocombe
force-pushed
the
fix/ivy/fw-1319-i18n-project-removed-nodes
branch
from
70feb6a
to
f121351
Compare
mhevery
approved these changes
Jun 5, 2019
alxhub
approved these changes
Jun 5, 2019
ocombe
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When translated content was projected, all of the content was reappended, even the placeholders that had been removed in the translation.
To avoid that we added a new flag on
TNodethat specifies that a node is detached, in which case it should be ignored by the projection.Ignore the first 3 commits that belong to the PRs #30696 and #30782. It should only be merged after these two.