New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bazel): do not modify tsconfig.json #30877
Conversation
@alexeagle This is now good to go, |
opt: update https://next.angular.io/guide/bazel#removing-bazel too |
Before this change, user's tsconfig.json is cloned and some options controlled by Bazel are removed otherwise Bazel would complain about: ``` WARNING: your tsconfig.json file specifies options which are overridden by Bazel: - compilerOptions.target and compilerOptions.module are controlled by downstream dependencies, such as ts_devserver - compilerOptions.typeRoots is always set to the @types subdirectory of the node_modules attribute - compilerOptions.rootDir and compilerOptions.baseUrl are always the workspace root directory ``` Since the warning has been removed in rules_typescript/8d8d398, there's no need to clone and backup tsconfig.json
@kyliau merging this PR to patch branch failed due to some conflicts. I've changed the label to "master-only" and merged it to master. Could you please create a separate PR and target patch branch? Thank you. |
This is a patch PR for angular#30877
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Before this change, user's tsconfig.json is cloned and some options
controlled by Bazel are removed otherwise Bazel would complain about:
Since the warning has been removed in rules_typescript/8d8d398, there's no
need to clone and backup tsconfig.json
PR Closes #30104
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information