Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zone.js): restore definition of global #31453

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

This partially reverts some changes from angular/zone.js@71b9371#diff-dd469785fca8680a5b33b1e81c5cfd91R1420
These broke the g3sync of zone.js because we use the output of the TypeScript compiler directly, rather than rely on the rollup commonjs plugin to define the global symbol

@alexeagle alexeagle requested a review from a team as a code owner July 8, 2019 18:31
@alexeagle
Copy link
Contributor Author

FYI the resulting change in the bundle looks like

alexeagle@alexeagle:~/Projects/angular$ diff /tmp/oldzone/package/dist/zone.js dist/bin/packages/zone.js/npm_package/dist/zone.js
11d10
<     var commonjsGlobal = typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};
651c650
<     })(commonjsGlobal);
---
>     })(typeof window !== 'undefined' && window || typeof self !== 'undefined' && self || global);

This partially reverts some changes from angular/zone.js@71b9371#diff-dd469785fca8680a5b33b1e81c5cfd91R1420
These broke the g3sync of zone.js because we use the output of the TypeScript compiler directly, rather than rely on the rollup commonjs plugin to define the global symbol
@alexeagle alexeagle added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed target: major This PR is targeted for the next major release labels Jul 8, 2019
Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@jasonaden jasonaden closed this in e6f1b04 Jul 9, 2019
jasonaden pushed a commit that referenced this pull request Jul 9, 2019
This partially reverts some changes from angular/zone.js@71b9371#diff-dd469785fca8680a5b33b1e81c5cfd91R1420
These broke the g3sync of zone.js because we use the output of the TypeScript compiler directly, rather than rely on the rollup commonjs plugin to define the global symbol

PR Close #31453
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants