Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): correctly bind targetToIdentifier to the TemplateVisitor #31861

Closed
wants to merge 1 commit into from

Conversation

ayazhafiz
Copy link
Member

TemplateVisitor#visitBoundAttribute currently has to invoke visiting
expressions manually (this is fixed in #31813). Previously, it did not
bind targetToIdentifier to the visitor before deferring to the
expression visitor, which breaks the targetToIdentifier code. This
fixes that and adds a test to ensure the closure processed correctly.

This change is urgent; without it, many indexing targets in g3 are
broken.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

`TemplateVisitor#visitBoundAttribute` currently has to invoke visiting
expressions manually (this is fixed in angular#31813). Previously, it did not
bind `targetToIdentifier` to the visitor before deferring to the
expression visitor, which breaks the `targetToIdentifier` code. This
fixes that and adds a test to ensure the closure processed correctly.

This change is urgent; without it, many indexing targets in g3 are
broken.
@ayazhafiz ayazhafiz added type: bug/fix target: major This PR is targeted for the next major release comp: ivy labels Jul 26, 2019
@ayazhafiz ayazhafiz requested a review from alxhub July 26, 2019 17:53
@ayazhafiz ayazhafiz requested a review from a team as a code owner July 26, 2019 17:53
@ayazhafiz ayazhafiz self-assigned this Jul 26, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jul 26, 2019
@ayazhafiz ayazhafiz added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 26, 2019
@ngbot
Copy link

ngbot bot commented Jul 26, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ayazhafiz
Copy link
Member Author

Caretaker: codefresh is flaky, please merge anyway. This is a small bug fix.

@ayazhafiz ayazhafiz deleted the fix/bind branch July 26, 2019 19:47
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
…ngular#31861)

`TemplateVisitor#visitBoundAttribute` currently has to invoke visiting
expressions manually (this is fixed in angular#31813). Previously, it did not
bind `targetToIdentifier` to the visitor before deferring to the
expression visitor, which breaks the `targetToIdentifier` code. This
fixes that and adds a test to ensure the closure processed correctly.

This change is urgent; without it, many indexing targets in g3 are
broken.

PR Close angular#31861
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants