Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): correctly bind targetToIdentifier to the TemplateVisitor #31861

Closed
wants to merge 1 commit into from
Closed

fix(ivy): correctly bind targetToIdentifier to the TemplateVisitor #31861

wants to merge 1 commit into from

Commits on Jul 26, 2019

  1. fix(ivy): correctly bind targetToIdentifier to the TemplateVisitor 

    `TemplateVisitor#visitBoundAttribute` currently has to invoke visiting
expressions manually (this is fixed in angular#31813). Previously, it did not
bind `targetToIdentifier` to the visitor before deferring to the
expression visitor, which breaks the `targetToIdentifier` code. This
fixes that and adds a test to ensure the closure processed correctly.

This change is urgent; without it, many indexing targets in g3 are
broken.
    @ayazhafiz
    ayazhafiz committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    2c135fb View commit details
    Browse the repository at this point in the history