test: make tree test work in g3 #32274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: benchpress
target: major
kyliau
force-pushed
the
tree-ivy
branch
2 times, most recently
from
40a9807
to
620f397
Compare
This PR modifies the tree render3 (ivy) test so that it works in g3. Namely, the index.ts must be named index_aot.ts and scripts should be loaded via ts_devserver and not as an explicit script tag in the HTML.
kyliau
added
the
merge: caretaker note
|
merge-assistance: global approval |
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
This PR modifies the tree render3 (ivy) test so that it works in g3. Namely, the index.ts must be named index_aot.ts and scripts should be loaded via ts_devserver and not as an explicit script tag in the HTML. PR Close angular#32274
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
This PR modifies the tree render3 (ivy) test so that it works in g3. Namely, the index.ts must be named index_aot.ts and scripts should be loaded via ts_devserver and not as an explicit script tag in the HTML. PR Close angular#32274
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the tree render3 (ivy) test so that it works in g3.
Namely, the index.ts must be named index_aot.ts and scripts should be
loaded via ts_devserver and not as an explicit script tag in the HTML.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information