Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Use ts.CompletionEntry for completions #32375

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Aug 28, 2019

This is a prerequisite to fix a bug in template completions whereby
completion of the string ti for the variable title results in
tititle.

This is because the position where the completion is requested is used
to insert the completion text. This is incorrect. Instead, a
replacementSpan should be used to indicate the span of text that needs
to be replaced. Angular's own Completion interface is insufficient to
hold this information. Instead, we should just use ts.CompletionEntry.

Also added string enum for CompletionKind, which is similar to
ts.ScriptElementKind but contains more info about HTML entities.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from ayazhafiz August 28, 2019 17:39
@kyliau kyliau requested a review from a team as a code owner August 28, 2019 17:39
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
packages/language-service/src/completions.ts Show resolved Hide resolved
packages/language-service/src/completions.ts Show resolved Hide resolved
packages/language-service/src/types.ts Outdated Show resolved Hide resolved
@atscott atscott added the area: language-service Issues related to Angular's VS Code language service label Aug 28, 2019
@ngbot ngbot bot added this to the needsTriage milestone Aug 28, 2019
@kyliau kyliau requested a review from a team as a code owner August 28, 2019 20:42
Copy link
Contributor Author

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Enum, the declaration itself should be CamelCase whereas the enum values should be CONSTANT_CASE.

packages/language-service/src/utils.ts Outdated Show resolved Hide resolved
@kyliau kyliau added the target: major This PR is targeted for the next major release label Aug 28, 2019
This is a prerequisite to fix a bug in template completions whereby
completion of the string `ti` for the variable `title` results in
`tititle`.

This is because the position where the completion is requested is used
to insert the completion text. This is incorrect. Instead, a
`replacementSpan` should be used to indicate the span of text that needs
to be replaced. Angular's own `Completion` interface is insufficient to
hold this information. Instead, we should just use ts.CompletionEntry.

Also added string enum for `CompletionKind`, which is similar to
ts.ScriptElementKind but contains more info about HTML entities.
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Sep 4, 2019
@mhevery mhevery closed this in f6e88cd Sep 4, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
…r#32375)

This is a prerequisite to fix a bug in template completions whereby
completion of the string `ti` for the variable `title` results in
`tititle`.

This is because the position where the completion is requested is used
to insert the completion text. This is incorrect. Instead, a
`replacementSpan` should be used to indicate the span of text that needs
to be replaced. Angular's own `Completion` interface is insufficient to
hold this information. Instead, we should just use ts.CompletionEntry.

Also added string enum for `CompletionKind`, which is similar to
ts.ScriptElementKind but contains more info about HTML entities.

PR Close angular#32375
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…r#32375)

This is a prerequisite to fix a bug in template completions whereby
completion of the string `ti` for the variable `title` results in
`tititle`.

This is because the position where the completion is requested is used
to insert the completion text. This is incorrect. Instead, a
`replacementSpan` should be used to indicate the span of text that needs
to be replaced. Angular's own `Completion` interface is insufficient to
hold this information. Instead, we should just use ts.CompletionEntry.

Also added string enum for `CompletionKind`, which is similar to
ts.ScriptElementKind but contains more info about HTML entities.

PR Close angular#32375
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019
@kyliau kyliau deleted the completions branch October 8, 2019 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants