fix(projection): allow to project to a non text node #3241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
added
the
action: review
| @@ -339,7 +339,7 @@ function updateElementBinderTextNodeIndices(elementBinder: DomElementBinder, | |||
| eventLocals: null, | |||
| localEvents: [], | |||
| globalEvents: [], | |||
| hasNativeShadowRoot: null | |||
| hasNativeShadowRoot: false | |||
There was a problem hiding this comment.
Is this field strictly a boolean or it has three states - null | false | true?
There was a problem hiding this comment.
Can you set it to false in the constructor, like
rkirov
added
pr_state: LGTM
and removed
action: review
We already had a test for this, but too low level that it did not catch this null value in `hasNativeShadowRoot` Fixes angular#3230
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a test for this, but too low level that it did not catch this null value in
hasNativeShadowRootFixes #3230