Listeners perf #32495
Closed
Listeners perf #32495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhevery
reviewed
Sep 5, 2019
|
|
||
| // profile create views (run templates in creation mode) | ||
| console.profile('create listeners'); | ||
| for (let i = 0; i < 500000; i++) { |
There was a problem hiding this comment.
Hey can we start using A better way to write perf tests
There was a problem hiding this comment.
Done, it is using the micro-harness right now.
pkozlowski-opensource
force-pushed
the
listeners_perf
branch
from
1c9e0a1
to
092f866
Compare
pkozlowski-opensource
added
comp: ivy
target: major
mhevery
approved these changes
Sep 10, 2019
mhevery
added
action: merge
pkozlowski-opensource
force-pushed
the
listeners_perf
branch
from
092f866
to
3f21f13
Compare
Before this refactoring we had 2 utility functions to check if a given TNode has matching directives. This PR leaves just one such function (one that does less memory read).
kara
pushed a commit
that referenced
this pull request
Sep 12, 2019
Before this refactoring we had 2 utility functions to check if a given TNode has matching directives. This PR leaves just one such function (one that does less memory read). PR Close #32495
kara
pushed a commit
that referenced
this pull request
Sep 12, 2019
kara
pushed a commit
that referenced
this pull request
Sep 12, 2019
kara
pushed a commit
that referenced
this pull request
Sep 12, 2019
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
Before this refactoring we had 2 utility functions to check if a given TNode has matching directives. This PR leaves just one such function (one that does less memory read). PR Close angular#32495
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new benchmark focused on listeners creation. It also contains small refactoring and performance improvement. Go over this PR commit-by-commit for easier review