Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error in Ivy mode with 9.0.0-next.5 #32506

Closed
sergey-morenets opened this issue Sep 6, 2019 · 7 comments
Closed

Compilation error in Ivy mode with 9.0.0-next.5 #32506

sergey-morenets opened this issue Sep 6, 2019 · 7 comments
Assignees
Milestone

Comments

@sergey-morenets
Copy link

sergey-morenets commented Sep 6, 2019

馃悶 bug report

Is this a regression?

No

Description

I have a working Angular v8 application that uses @agm/core(1.0.0-beta.7) dependency. I tried to upgrade to 9.0.0-next.5 to verify that Ivy mode works properly:

"angularCompilerOptions": {
"enableIvy": true
}

But in Ivy mode I get the error messages. In non-Ivy mode everything works fine.

馃敩 Minimal Reproduction

ng build --prod

馃敟 Exception or Error

error TS8002: 'longitude' is not a valid property of <agm-map>.
<agm-map [latitude]="latitude" [longitude]="longitude" [zoom]="zoom">

error TS8002: 'zoom' is not a valid property of <agm-map>.
<agm-map [latitude]="latitude" [longitude]="longitude" [zoom]="zoom">

error TS8001: 'agm-marker' is not a valid HTML element.
<agm-marker [latitude]="latitude" [longitude]="longitude"></agm-marker>

馃實 Your Environment

Angular Version:


Angular CLI: 9.0.0-next.3
Node: 12.3.1
OS: win32 x64
Angular: 9.0.0-next.5
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-next.3
@angular-devkit/build-angular     0.900.0-next.3
@angular-devkit/build-optimizer   0.900.0-next.3
@angular-devkit/build-webpack     0.900.0-next.3
@angular-devkit/core              9.0.0-next.3
@angular-devkit/schematics        9.0.0-next.3
@angular/cdk                      8.1.4
@angular/cli                      9.0.0-next.3
@angular/material                 8.1.4
@ngtools/webpack                  9.0.0-next.3
@schematics/angular               9.0.0-next.3
@schematics/update                0.900.0-next.3
rxjs                              6.5.3
typescript                        3.5.3
webpack                           4.39.3
@pshurygin
Copy link

AGM is not compatible with ivy. This has been fixedin the agm repo, but the fix has not yet been released to npm. Here is the relevant thread
sebholstein/angular-google-maps#1647

@ngbot ngbot bot added this to the needsTriage milestone Sep 10, 2019
@sergey-morenets
Copy link
Author

@pshurygin Thank you for the explanation.

But this thread seems to be closed(without publishing new agm version). So how should we react? Give up the idea of using Ivy in our application or move to other Google Maps library?

@pshurygin
Copy link

I guess it will be published eventually, as the fix is already merged into master branch.

@JoostK
Copy link
Member

JoostK commented Sep 26, 2019

Looked into this just now, @agm/core 1.0.0 has bundles which has decorators represented in a way that is strange to me. I'm looking into it.

@JoostK
Copy link
Member

JoostK commented Oct 10, 2019

@sergey-morenets Could you please test again with the 9.0.0-next.10 release, as I believe the issue with @agm/core has been resolved in #32901 (which is in next.9, even).

@sergey-morenets
Copy link
Author

@JoostK Yes, it's not reproduced any more with the latest version of @agm/core

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants