fix(ngcc): handle presence of both ctorParameters and __decorate

[JoostK]

Recently ng-packagr was updated to include a transform that used to be
done in tsickle (ng-packagr/ng-packagr#1401),
where only constructor parameter decorators are emitted in tsickle's
format, not any of the other decorators.

ngcc used to extract decorators from only a single format, so once it
saw the ctorParameters static property it assumed the library is using
the tsickle format. Therefore, none of the __decorate calls were
considered. This resulted in missing decorator information, preventing
proper processing of a package.

This commit changes how decorators are extracted by always looking at
both the static properties and the __decorate calls, merging these
sources appropriately.

Resolves FW-1573

[petebacondarwin]

Is there a typo in the commit message?

ngcc used to only a single format,

[petebacondarwin]

LGTM - I wonder if there is a risk that tools like ng-packagr may mix such decorator styles even more loosely? In which case, should we just change the code to look for both types of decorator always and then merge the two sets that are discovered? This would make use resilient to such tooling changes in the future. The only downside would be a small performance loss, right?

[gkalpak]

+1 for always looking for both types of decorators and then merging the two sets (unless the performance decrease is significant).

Otherwise lgtm2 👍

[JoostK]

I thought about merging the two and decided not to, as it would require some merging strategy that may depend yet again on how tooling generates code. However I see now that before the refactoring in #31614 we were essentially already merging the two formats, so it makes sense to start doing that again.

[JoostK]

@petebacondarwin I fixed the commit message and pushed a fixup commit so that the two decorator sources are now merged, preferring static properties.

Regarding performance, I don't expect it to matter that much. Recall that for non-tsickle libraries we were already executing both code paths.

[naveedahmed1]

I hope this will be added in next release :)

[JoostK]

@naveedahmed1 It should be available in 9.0.0-next.9 right about now! :D

[naveedahmed1]

Awesome, thank you @JoostK for the update :)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}