Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update migration descriptions with links to AIO documentation #32991

Closed
wants to merge 2 commits into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

9.0 migrations did not contain references to the AIO documentation describing the migrations.

What is the new behavior?

9.0 migrations that have accompanying documentation now have links to the aforementioned documentation. The versions for the migration schematics were also corrected to use a valid semver version.

Does this PR introduce a breaking change?

  • No

Other information

@clydin clydin requested a review from a team as a code owner October 4, 2019 01:02
packages/core/schematics/migrations.json Outdated Show resolved Hide resolved
packages/core/schematics/migrations.json Outdated Show resolved Hide resolved
packages/core/schematics/migrations.json Outdated Show resolved Hide resolved
@atscott atscott added the area: core Issues related to the framework runtime label Oct 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Oct 4, 2019
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

@kara kara added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Oct 4, 2019
@alxhub alxhub closed this in f8eca84 Oct 4, 2019
@clydin clydin deleted the update-9.0-migration-descs branch October 4, 2019 20:59
@devversion
Copy link
Member

@clydin The version's in the migration collection were actually valid in terms of ng update. See: https://github.com/angular/angular-cli/blob/master/packages/schematics/update/migrate/index.ts#L76.

Though I agree that it's s good to make them semver compliant anyway (even though it doesn't change anything in terms of the migration). Are there plans to remove this version coercion from the CLI?

@clydin
Copy link
Member Author

clydin commented Oct 7, 2019

It is indeed valid for ng update's version of a version. However, any other tool that happens to use the files should ideally not be required to implement ng update's non-standard semantics. However, with such versions already in the field, the CLI will need to maintain support for these versions and the code to parse them for the foreseeable future.

ODAVING pushed a commit to ODAVING/angular that referenced this pull request Oct 18, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants