Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add check for git message formatting #3337

Closed
jeffbcross opened this issue Jul 28, 2015 · 3 comments
Closed

chore(ci): add check for git message formatting #3337

jeffbcross opened this issue Jul 28, 2015 · 3 comments
Labels
area: build & ci Related the build and CI infrastructure of the project effort1: hours

Comments

@jeffbcross
Copy link
Contributor

We should have a script that runs on Travis to enforce git commit message guidelines, to prevent accidental merging of commits with messages that don't conform to requirements established here

Yes, this would be a slight inconvenience for "WIP" PRs, but worth the assurance of preventing pushes to master while forgetting to check a commit message, and needing to force-push to fix.
@mhevery
Copy link
Contributor

mhevery commented Aug 24, 2015

I think we already have one here: https://github.com/angular/angular.js/blob/master/validate-commit-msg.js

@vvo
Copy link

vvo commented Sep 29, 2015

I think you can have multiple checks so that you see that tests passes for ongoing PRs

I think we already have one here: https://github.com/angular/angular.js/blob/master/validate-commit-msg.js

Yep just need to run it in another CI check

@mhevery mhevery added area: build & ci Related the build and CI infrastructure of the project and removed comp: build/pipeline labels Sep 7, 2016
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
b10e5c7 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
db5c9ed 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
66bf7cf 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
4d7ddbd 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
3605b47 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
dda40c2 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
3c3087f 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
6b68119 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
a68ab31 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
7d89b8e 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
8200840 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
923376a 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 20, 2017
@IgorMinar
ci: validate the message of each new commit as part of the CI linting
619db5f 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
@alxhub alxhub closed this as completed in dff6ee3 Jan 23, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@IgorMinar @juleskremer
ci: validate the message of each new commit as part of the CI linting
dbcb135 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
idlechara pushed a commit to idlechara/angular that referenced this issue Apr 27, 2021
@IgorMinar @alxhub
ci: validate the message of each new commit as part of the CI linting
d169e31 
This patch adds the gulp command of `validate-commit-messages`
which will validate the range of commits messages present in the
active branch.

This check now runs on CI as part of the linting checks.

Allowed commit message types and scopes are controlled via commit-message.json file
and documented at https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

This solution is based on old Vojta's code that he wrote for angular/angular.js, that was later adjusted
by @matsko in angular#13815.

Ideally we should switch over to something like https://www.npmjs.com/package/commitplease
as suggested in angular#9953 but that package currently doesn't support strict scope checking,
which is one of the primarily goal of this PR.

Note that this PR removes support for "chore" which was previously overused
by everyone on the team.

Closes angular#13815
Fixes angular#3337
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project effort1: hours
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mhevery @vvo @IgorMinar @jeffbcross @naomiblack