New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input coercion static members cannot be used with NGC and strictMetadataEmit enabled #33451

Closed

devversion opened this issue Oct 28, 2019 · 3 comments

Labels

area: compiler freq2: medium hotlist: components team type: bug/fix

Milestone

Member

devversion commented Oct 28, 2019 •

edited

🐞 bug report

Affected Package

@angular/compiler-cli

Is this a regression?

No

Description

Switching between ngtsc and ngc is not possible when coercion static members are declared for components. e.g.

class MyComp {
  ...

  static ngAcceptInputType_disabled: boolean | string;
}

This works as expected in ngtsc, but as soon as the project is compiled with ngc, the metadata validator throws an exception:

Error encountered in metadata generated for exported symbol 'MyComp': 
 /home/circleci/ng/src/cdk/my-comp.ts:422:10: 

Metadata collected contains an error that will be reported at runtime: Only initialized variables and constants can be referenced because the value of this variable is needed by the template compiler.
  {"__symbolic":"error","message":"Variable not initialized","line":421,"character":9}

The error for the static members is actually valid since it only happens if strictMetadataEmit is enabled.. and this means that NGC validates that there is no unresolved symbol in the source file metadata. Though, since libraries want to keep that flag enabled to ensure that the metadata works in all cases, we need a way to skip accept coercion members for Ivy/ViewEngine compatibility.

The text was updated successfully, but these errors were encountered:

devversion added the hotlist: components team label

devversion changed the title ~~ngtsc input coercion static members cannot be used with ngc~~ Input coercion static members cannot be used with NGC and strictMetadataEmit enabled

devversion mentioned this issue

feat: expand input types with coercion to work with ngtsc input type checking angular/components#17528

Merged

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

b7ea0a9

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

c6f1a98

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

a08ac4b

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

08683a7

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: disable strict metadata emit for legacy build output

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

ad1a0a1

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: disable strict metadata emit for legacy build output

449234b

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

355e8a9

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: disable strict metadata emit for legacy build output

31f19bd

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

1d6de5e

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: disable strict metadata emit for legacy build output

f1dc077

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

0cbf75a

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: disable strict metadata emit for legacy build output

94e3d65

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

devversion added a commit to devversion/material2 that referenced this issue


          refactor: add workaround for strict metadata emit of coercion static …

35430ff

…members

See: angular/angular#33451

devversion added a commit to devversion/material2 that referenced this issue


          refactor: disable strict metadata emit for legacy build output

920102a

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

andrewseguin pushed a commit to angular/components that referenced this issue


          feat: expand input types with coercion to work with ngtsc input type …

8da64f4

…checking (#17528)

* feat: expand input types with coercion to work with ngtsc input type checking

* refactor: add workaround for strict metadata emit of coercion static members

See: angular/angular#33451

* build: patch ng_module bazel rule to enable strict template type checking

Workaround for: angular/angular#33452

* refactor: disable strict metadata emit for legacy build output

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

* build: disable strict attribute type checking

We are temporarily disabling strict attribute type checking
since we have a few templates that set a coerced input while
the `NgModel` directive is applied. In those cases, the empty string
for the `disabled` input, is not assignable to the `NgModel#disabled` input,
since it does not do coercion. We need to figure out what to do in those
scenarios.

atscott added the area: compiler label

ngbot bot added this to the needsTriage milestone

Member

alxhub commented Dec 5, 2019

Maybe just assign it to null!?

alxhub added freq2: medium severity3: broken type: bug/fix labels

ngbot bot modified the milestones: needsTriage, Backlog

Member

alxhub commented Jan 28, 2020

Fixed in #34296.

alxhub closed this as completed

angular-automatic-lock-bot bot commented Feb 28, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.