fix(browser_adapter): fix clearNodes() in IE #3355
Conversation
pkozlowski-opensource
force-pushed
the
issue3295
branch
from
6542f57
to
2f1f213
Compare
| @@ -130,14 +130,14 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter { | |||
| } | |||
| clearNodes(el) { | |||
| while (el.firstChild) { | |||
| el.firstChild.remove(); | |||
| el.removeChild(el.firstChild); | |||
There was a problem hiding this comment.
can you write a comment that can explain the reason why the refactor is needed or simply a comment with a url to the issue
There was a problem hiding this comment.
@gdi2290 this commit has a reference to the original issue, so hopfully it should be enough. And as soon as we plug other browsers on the CI it will be self-verifying.
There was a problem hiding this comment.
you're right I jumped to conclusion and we have github/git blame/CI for a reason. If someone were to optimize this they would first check git blame then the git commit history before proceeding and if that fails CI will prevail. With all that said, comments are important to show hot path, document unorthodox/failed optimizations, unimportant technical debt via TODO:, or code documentation
|
LGTM, this solves issue #3295 in IE11 |
marclaval
added
pr_state: LGTM
action: merge
|
Thnx @Mlaval for the review. I'm going to land it as soon as we get master back to green. |
|
Please create a presubmit branch... |
pkozlowski-opensource
force-pushed
the
issue3295
branch
from
2f1f213
to
e95f8fa
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #3295