Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): create factory in providerToRecord only when needed #33742

Conversation

NothingEverHappens
Copy link
Contributor

@NothingEverHappens NothingEverHappens commented Nov 11, 2019

In providerToRecord move creating the factory into a condition which actually needs it to avoid unnecessary creating it

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Factory gets created unnecessary

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • No

Other information

@NothingEverHappens NothingEverHappens requested a review from a team as a code owner November 11, 2019 20:49
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

In providerToRecord move creating the factory into a condition which
actually needs it to avoid unnecessary creating it
@AndrewKushnir AndrewKushnir added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 11, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 11, 2019
@AndrewKushnir AndrewKushnir self-assigned this Nov 11, 2019
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 11, 2019
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 11, 2019

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir AndrewKushnir changed the title perf(core): In providerToRecord only create factory when needed perf(core): create factory in providerToRecord only when needed Nov 12, 2019
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 12, 2019
@AndrewKushnir AndrewKushnir removed their assignment Nov 12, 2019
@kara kara closed this in ccee818 Nov 12, 2019
kara pushed a commit that referenced this pull request Nov 12, 2019
In providerToRecord move creating the factory into a condition which
actually needs it to avoid unnecessary creating it

PR Close #33742
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants