New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): create factory in providerToRecord only when needed #33742
perf(core): create factory in providerToRecord only when needed #33742
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
c309f27
to
0e1ac98
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
0e1ac98
to
3ac9d16
Compare
In providerToRecord move creating the factory into a condition which actually needs it to avoid unnecessary creating it
3ac9d16
to
945589a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
In providerToRecord move creating the factory into a condition which actually needs it to avoid unnecessary creating it PR Close #33742
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In providerToRecord move creating the factory into a condition which actually needs it to avoid unnecessary creating it
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Factory gets created unnecessary
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information