Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): recompile on template change in ngc watch mode on Windows #34015

Closed
wants to merge 1 commit into from
Closed

fix(ivy): recompile on template change in ngc watch mode on Windows #34015

wants to merge 1 commit into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented Nov 23, 2019

In #33551, a bug in ngc --watch mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes #32869

@JoostK JoostK added type: bug/fix severity3: broken target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Nov 23, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 23, 2019
@JoostK JoostK force-pushed the ngtsc-watch-templates branch 2 times, most recently from 0ca421f to b714f5a Compare November 24, 2019 19:23
@JoostK
Copy link
Member Author

JoostK commented Nov 24, 2019

@stefanocke Hi Stefan, could you please test the artifacts from this PR on Windows?

Artifacts: https://app.circleci.com/jobs/github/angular/angular/540987/artifacts
Instructions: https://github.com/angular/angular/blob/master/docs/DEVELOPER.md#archives-for-each-package

I am expecting this PR to fix your issue, hoping you can confirm. Thanks!

@stefanocke
Copy link

@JoostK , it works for me. :-)

@stefanocke
Copy link

Hello @JoostK , any chance to get it merged in the next RC? Thank you.

@JoostK
Copy link
Member Author

JoostK commented Dec 23, 2019

@stefanocke yeah, I can look into reviving this PR. There has been quite some work around incremental compilations and dependency tracking that conflicted heavily with this PR so it has gotten outdated.

@JoostK JoostK force-pushed the ngtsc-watch-templates branch 3 times, most recently from baa7193 to c129137 Compare January 18, 2020 21:14
@JoostK JoostK marked this pull request as ready for review January 18, 2020 21:42
@JoostK JoostK requested review from a team as code owners January 18, 2020 21:42
petebacondarwin
petebacondarwin approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor concern.
Thanks @JoostK !

packages/compiler-cli/src/perform_watch.ts Show resolved Hide resolved
@pullapprove pullapprove bot requested a review from devversion January 29, 2020 20:25
@JoostK JoostK removed the request for review from devversion February 3, 2020 21:27
@pullapprove pullapprove bot requested a review from devversion February 3, 2020 21:27
@JoostK JoostK added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: presubmit The PR is in need of a google3 presubmit labels Feb 3, 2020
@JoostK
Copy link
Member Author

JoostK commented Feb 3, 2020

merge-assistance: Pete's review should be sufficient, I am code-owner of fw-compiler.

devversion
devversion approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the BUILD file update (for which pullapprove requested review from dev-infra)

@JoostK
fix(ivy): recompile on template change in ngc watch mode on Windows
d522f9f 
In angular#33551, a bug in `ngc --watch` mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes angular#32869
@mhevery
Copy link
Contributor

mhevery commented Feb 4, 2020

presubmit

mhevery pushed a commit that referenced this pull request Feb 4, 2020
@JoostK @mhevery
fix(ivy): recompile on template change in ngc watch mode on Windows (#…
a5c9cd7 
…34015)

In #33551, a bug in `ngc --watch` mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes #32869

PR Close #34015
@mhevery mhevery closed this in 5cada5c Feb 4, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@JoostK @sonukapoor
fix(ivy): recompile on template change in ngc watch mode on Windows (a…
f4f4db5 
…ngular#34015)

In angular#33551, a bug in `ngc --watch` mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes angular#32869

PR Close angular#34015
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
@JoostK @sonukapoor
fix(ivy): recompile on template change in ngc watch mode on Windows (a…
1c06685 
…ngular#34015)

In angular#33551, a bug in `ngc --watch` mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes angular#32869

PR Close angular#34015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: compiler Issues related to `ngc`, Angular's template compiler cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

ngc --watch ignores changes in templates (ivy, 9.0.0-next.8)
6 participants
@JoostK @stefanocke @mhevery @petebacondarwin @devversion @googlebot