fix(ngcc): capture entry-point dependencies from typings as well as source #34494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
type: bug/fix
action: review
petebacondarwin
force-pushed
the
ngcc-typings-dependency-host
branch
from
f556191
to
fd0629f
Compare
JoostK
reviewed
Dec 19, 2019
packages/compiler-cli/ngcc/test/dependencies/dependency_resolver_spec.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/test/dependencies/dependency_resolver_spec.ts
Show resolved
Hide resolved
|
Could you update the commit message to include the fixes #34411 reference? |
petebacondarwin
force-pushed
the
ngcc-typings-dependency-host
branch
2 times, most recently
from
8675f98
to
1bdb64e
Compare
petebacondarwin
force-pushed
the
ngcc-typings-dependency-host
branch
from
1bdb64e
to
75dadbf
Compare
gkalpak
approved these changes
Dec 23, 2019
packages/compiler-cli/ngcc/test/dependencies/dependency_resolver_spec.ts
Show resolved
Hide resolved
gkalpak
added
the
action: cleanup
Rather than return a new object of dependency info from calls to `collectDependencies()` we now pass in an object that will be updated with the dependency info. This is in preparation of a change where we will collect dependency information from more than one `DependencyHost`. Also to better fit with this approach the name is changed from `findDependencies()` to `collectDependencies()`.
petebacondarwin
force-pushed
the
ngcc-typings-dependency-host
branch
from
75dadbf
to
4ca6faf
Compare
The `DependencyHost` implementations were duplicating the "postfix" strings which are used to find matching paths when resolving module specifiers. Now the hosts reuse the postfixes given to the `ModuleResolver` that is passed to the host.
…ource ngcc computes a dependency graph of entry-points to ensure that entry-points are processed in the correct order. Previously only the imports in source files were analysed to determine the dependencies for each entry-point. This is not sufficient when an entry-point has a "type-only" dependency - for example only importing an interface from another entry-point. In this case the "type-only" import does not appear in the source code. It only appears in the typings files. This can cause a dependency to be missed on the entry-point. This commit fixes this by additionally processing the imports in the typings program, as well as the source program. Note that these missing dependencies could cause unexpected flakes when running ngcc in async mode on multiple processes due to the way that ngcc caches files when they are first read from disk. Fixes angular#34411 // FW-1781
petebacondarwin
force-pushed
the
ngcc-typings-dependency-host
branch
from
4ca6faf
to
d21b34e
Compare
petebacondarwin
removed
the
action: cleanup
|
RE performance change: note that this change only affects the dependency analysis phase, which is around 7.4% of the total processing time (using integration/cli-hello-world-ivy-compat). After this PR the average percentage goes up to around 7.8%. |
petebacondarwin
removed
the
action: review
petebacondarwin
added
the
action: merge
alxhub
approved these changes
Jan 7, 2020
alxhub
pushed a commit
that referenced
this pull request
Jan 7, 2020
Rather than return a new object of dependency info from calls to `collectDependencies()` we now pass in an object that will be updated with the dependency info. This is in preparation of a change where we will collect dependency information from more than one `DependencyHost`. Also to better fit with this approach the name is changed from `findDependencies()` to `collectDependencies()`. PR Close #34494
alxhub
pushed a commit
that referenced
this pull request
Jan 7, 2020
…ource (#34494) ngcc computes a dependency graph of entry-points to ensure that entry-points are processed in the correct order. Previously only the imports in source files were analysed to determine the dependencies for each entry-point. This is not sufficient when an entry-point has a "type-only" dependency - for example only importing an interface from another entry-point. In this case the "type-only" import does not appear in the source code. It only appears in the typings files. This can cause a dependency to be missed on the entry-point. This commit fixes this by additionally processing the imports in the typings program, as well as the source program. Note that these missing dependencies could cause unexpected flakes when running ngcc in async mode on multiple processes due to the way that ngcc caches files when they are first read from disk. Fixes #34411 // FW-1781 PR Close #34494
alxhub
pushed a commit
that referenced
this pull request
Jan 7, 2020
…ource (#34494) ngcc computes a dependency graph of entry-points to ensure that entry-points are processed in the correct order. Previously only the imports in source files were analysed to determine the dependencies for each entry-point. This is not sufficient when an entry-point has a "type-only" dependency - for example only importing an interface from another entry-point. In this case the "type-only" import does not appear in the source code. It only appears in the typings files. This can cause a dependency to be missed on the entry-point. This commit fixes this by additionally processing the imports in the typings program, as well as the source program. Note that these missing dependencies could cause unexpected flakes when running ngcc in async mode on multiple processes due to the way that ngcc caches files when they are first read from disk. Fixes #34411 // FW-1781 PR Close #34494
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See FW-1781 for the background
Fixes #34411