fix(ivy): ensure that LOCALE_ID is set after app initializers
#34830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
type: bug/fix
action: review
petebacondarwin
added
the
action: presubmit
ocombe
approved these changes
Jan 17, 2020
alfaproject
reviewed
Jan 17, 2020
packages/core/src/application_ref.ts
Outdated
| @@ -315,6 +310,12 @@ export class PlatformRef { | |||
| const initStatus: ApplicationInitStatus = moduleRef.injector.get(ApplicationInitStatus); | |||
| initStatus.runInitializers(); | |||
| return initStatus.donePromise.then(() => { | |||
| // If the `LOCALE_ID` provider is defined at bootstrap we set the value for runtime i18n | |||
| // (ivy) | |||
There was a problem hiding this comment.
This (ivy) bit seems highly redundant considering how close it is to the next condition
AndrewKushnir
approved these changes
Jan 17, 2020
AndrewKushnir
removed
the
action: review
Before ivy it was possible to configure a mutable service value in an application initializer (by providing an `APP_INITIALIZER`) that could be read in the provider of `LOCALE_ID`. This is a common scenario if you wanted to load the locale id asynchronously from an HTTP request for instance. When using the ivy, the runtime needs to be told what the current locale is, which is done by calling the `setLocaleId()` function with the value injected by the `LOCALE_ID` token. Previously this was being done before the application initializers were run, which meant that the `LOCALE_ID` provider was being executed before the app initializers had a chance to get a new value for it. Now this initalization of the locale for the ivy runtime is done after the application initializers have been run. Closes angular#34701
petebacondarwin
force-pushed
the
i18n-locale-app-initializer
branch
from
d96581d
to
a6b86b7
Compare
|
@AndrewKushnir - I updated the comment per the suggestion by @alfaproject above. This should not affect the presubmit. |
AndrewKushnir
added
action: merge
matsko
pushed a commit
that referenced
this pull request
Jan 17, 2020
Before ivy it was possible to configure a mutable service value in an application initializer (by providing an `APP_INITIALIZER`) that could be read in the provider of `LOCALE_ID`. This is a common scenario if you wanted to load the locale id asynchronously from an HTTP request for instance. When using the ivy, the runtime needs to be told what the current locale is, which is done by calling the `setLocaleId()` function with the value injected by the `LOCALE_ID` token. Previously this was being done before the application initializers were run, which meant that the `LOCALE_ID` provider was being executed before the app initializers had a chance to get a new value for it. Now this initalization of the locale for the ivy runtime is done after the application initializers have been run. Closes #34701 PR Close #34830
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before ivy it was possible to configure a mutable service value
in an application initializer (by providing an
APP_INITIALIZER)that could be read in the provider of
LOCALE_ID. This is a commonscenario if you wanted to load the locale id asynchronously from
an HTTP request for instance.
When using the ivy, the runtime needs to be told what the current
locale is, which is done by calling the
setLocaleId()function withthe value injected by the
LOCALE_IDtoken. Previously this wasbeing done before the application initializers were run, which meant
that the
LOCALE_IDprovider was being executed before theapp initializers had a chance to get a new value for it.
Now this initalization of the locale for the ivy runtime is done after the
application initializers have been run.
Closes #34701